Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis URL #102

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix Redis URL #102

merged 1 commit into from
Oct 16, 2023

Conversation

zugao
Copy link
Collaborator

@zugao zugao commented Oct 11, 2023

This small PR will expose properly the URL.
Previously it would expose the IP not it will expose the full hostname.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • I have run successfully make test-e2e locally.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@zugao zugao added the bug Something isn't working label Oct 11, 2023
Copy link
Member

@TheBigLee TheBigLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zugao zugao merged commit b0fba61 into master Oct 16, 2023
3 checks passed
@zugao zugao deleted the fix/redis-url branch October 16, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants