forked from deepset-ai/haystack
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: Remove all mentions of Canals (deepset-ai#6844)
* Remove unnecessary Connection class * Remove all mentions of canals * Add release notes
- Loading branch information
1 parent
9211f53
commit f5e6133
Showing
9 changed files
with
65 additions
and
59 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,11 @@ | ||
# SPDX-FileCopyrightText: 2022-present deepset GmbH <[email protected]> | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
from typing import get_args, List, Type, Any | ||
import logging | ||
from dataclasses import dataclass, field | ||
from typing import Any, List, Type, get_args | ||
|
||
from haystack.core.component.types import CANALS_VARIADIC_ANNOTATION | ||
|
||
from haystack.core.component.types import HAYSTACK_VARIADIC_ANNOTATION | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
@@ -30,7 +29,7 @@ def is_mandatory(self): | |
def __post_init__(self): | ||
try: | ||
# __metadata__ is a tuple | ||
self.is_variadic = self.type.__metadata__[0] == CANALS_VARIADIC_ANNOTATION | ||
self.is_variadic = self.type.__metadata__[0] == HAYSTACK_VARIADIC_ANNOTATION | ||
except AttributeError: | ||
self.is_variadic = False | ||
if self.is_variadic: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
releasenotes/notes/remove-canals-mentions-eac7f95df99d39b9.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
fixes: | ||
- | | ||
Remove all mentions of Canals by renaming some variables. | ||
`__canals_input__` and `__canals_ouput__` have been renamed respectively to `__haystack_input__` and `__haystack_ouput__`. | ||
`CANALS_VARIADIC_ANNOTATION` has been renamed to `HAYSTACK_VARIADIC_ANNOTATION` and it's value changed from `__canals__variadic_t` to `__haystack__variadic_t`. | ||
Default Pipeline `debug_path` has been changed from `.canals_debug` to `.haystack_debug`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters