Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blog post on Distro Puppet acceptance testing #328

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 18, 2023

No description provided.

Within Vox Pupuli we maintain a lot of modules.
Keeping those healthy is a challenge and having working acceptance tests makes that feasible.
For each operating system we need two things: a working (container) image and Puppet.
The former is generally easy (except for operating systems with licenses), but for the we need some system packages.
Copy link
Member

@bastelfreak bastelfreak Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the we? Do you mean for the latter we?

@bschonec
Copy link

Thank you. This does make it easier for an amateur like me to get started on the journey of contributing to Voxpupuli.

Keeping those healthy is a challenge and having working acceptance tests makes that feasible.
For each operating system we need two things: a working (container) image and Puppet.
The former is generally easy (except for operating systems with licenses), but for the we need some system packages.
Until recently we've relied Puppet's [RPM](https://yum.puppet.com/) and [deb](https://apt.puppet.com/) packages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've relied Puppet's or we've relied on Puppet's?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, line 15, "but for the we"

With this in place, it's possible to start supporting the recently released Debian 12.

It's also a good chance to dive a bit deeper in how this is done.
Back in February I gave [a talk](https://cfp.cfgmgmtcamp.org/2023/talk/DWBWFX/) on this, but there was a lot of information in there and a written form may useful.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

written form may useful or written form may be useful?

@ekohl
Copy link
Member Author

ekohl commented Oct 18, 2023

As a side note: we should not publish this until our modulesync has been updated with voxpupuli/modulesync_config#855.

@ekohl ekohl force-pushed the add-blog-for-distro-puppet-acceptance-tests branch from 262613a to e4c9d1c Compare October 18, 2023 12:12
It parses `metadata.json` and builds a [list of supported operating systems](https://github.com/voxpupuli/puppet_metadata/blob/ff57b5e1fbc5ea09c6d4e5ca91e8e983f56d5585/lib/puppet_metadata/github_actions.rb#L50-L75).
For every operating system it iterates the OS releases (except for rolling releases like Archlinux and Gentoo).
For each release, it iterates the supported Puppet versions (also derived from `metadata.json`) and checks if it can find a Puppet version.
If there's an AIO build (determined using [PuppetMetadata::AIO](https://github.com/voxpupuli/puppet_metadata/blob/master/lib/puppet_metadata/aio.rb)) then that's preferred.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If there's an AIO build (determined using [PuppetMetadata::AIO](https://github.com/voxpupuli/puppet_metadata/blob/master/lib/puppet_metadata/aio.rb)) then that's preferred.
If there's an AIO (all-in-one) build (determined using [PuppetMetadata::AIO](https://github.com/voxpupuli/puppet_metadata/blob/master/lib/puppet_metadata/aio.rb)) then that's preferred.

@ekohl ekohl force-pushed the add-blog-for-distro-puppet-acceptance-tests branch from e4c9d1c to 580c298 Compare October 25, 2023 14:15
@ekohl ekohl force-pushed the add-blog-for-distro-puppet-acceptance-tests branch from 580c298 to 098489b Compare October 25, 2023 14:15
@ekohl
Copy link
Member Author

ekohl commented Oct 25, 2023

Addressed the last issue. Also rebased and updated the date to $today.

@bastelfreak bastelfreak merged commit 7eaa9b7 into master Oct 25, 2023
2 checks passed
@bastelfreak bastelfreak deleted the add-blog-for-distro-puppet-acceptance-tests branch October 25, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants