Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gha #923

Merged
merged 4 commits into from
Sep 5, 2023
Merged

update gha #923

merged 4 commits into from
Sep 5, 2023

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Aug 31, 2023

  • use upstream gha to build and publish container
  • add test step if container build still works, no publish
  • also build for arm64

@rwaffen
update gha
5c6b31e 
- use upstream gha to build and publish container
- add test step if container build still works, no publish
@rwaffen rwaffen requested a review from gdubicki August 31, 2023 15:40
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (218b6be) 76.87% compared to head (6baef08) 76.87%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   76.87%   76.87%           
=======================================
  Files          20       20           
  Lines        1310     1310           
=======================================
  Hits         1007     1007           
  Misses        303      303

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwaffen
change to v1 instead of commit id
2672960 
- also remove empty line
gdubicki
gdubicki approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@gdubicki gdubicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @rwaffen!

@rwaffen rwaffen merged commit 6084374 into voxpupuli:master Sep 5, 2023
9 checks passed
@rwaffen rwaffen deleted the update_gha branch September 5, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@gdubicki gdubicki gdubicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwaffen @bastelfreak @gdubicki