add possibility to manage network interfaces with a template

[trefzer]

This gives the possibility to manage all network/netdev/link settings from hashes.

I'm aware of pull request #340 from @rwaffen which started an equal solution last year.
Since the development there does not seem to go on, I started this solution which currrently
gives us the opportunitiy to create any configuration stated in the systemd documentation.

All type defintions are taken out of systemd documentation (not documented, not in our type defintion).
I'm aware, that some types could defined more accurate, but I tried to get a compromise inbetween accurate type and
workload ;).

[kenyon]

Better to put the closing braces on separate lines to avoid the need for double indentation:

Suggested change

	fname => "${_filename}.link",
	config => deep_merge(pick($link_profiles[$interface_name], {}), $interface['link']),
	}),
	fname => "${_filename}.link",
	config => deep_merge(pick($link_profiles[$interface_name], {}), $interface['link']),
	},
	),

[trefzer]

I don't think that this makes the code better readable. I will not change that for now.

[kenyon]

It does. The double indentation that you have to do currently is really just a bug in puppet-lint, I think.

[trefzer]

no the double intentation is correct since there are to brackets to intent.
to clarify:
my solution:

epp('template, {
    var => val,
})

your solution:

epp('template,
 {
    var => val,
 }
)

[kenyon]

Yes, IMO it is easier to follow the indentation when there is only at most one level of change between each line (your example has var => val, indented one level too far in my solution), easier to match up the opening and closing braces, and reduces diffs when adding and removing items to the comma-separated lists by already having separate lines.

[trefzer]

I made a test commit with your suggestion. I expect it to fail on validation test ! let's see

[trefzer]

ok validatio now fails, the it needs 12 spaces, no way to lower that.
I will remove the last commit tomorrow. Think we can resolv this.

[kenyon]

Right, it's clearly not correct to have the closing brace on the same line as the content inside of the brace. You'd have to also move the opening brace and fix the indentation.