RFC: add Kube unit support #473
Closed
+69
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jul 4, 2024
| @@ -4,7 +4,7 @@ | |||
| # | |||
| # @see systemd.unit(5) | |||
| # | |||
| # @param name [Pattern['^[^/]+\.(service|socket|device|mount|automount|swap|target|path|timer|slice|scope)$']] | |||
| # @param name [Pattern['^[^/]+\.(service|socket|device|mount|automount|swap|target|path|timer|slice|scope|kube)$']] | |||
There was a problem hiding this comment.
I think we shouldn't document it here, that's already in the type alias definition.
|
Sorry I made a mistake, apparently there is a utility to run that will generate a service unit from the definition of the .kube file. systemd will not directly read kube units so it makes no sense to make this PR here... |
|
I tried adding quadlet support southalc/podman#83 which ,kube is an example of. Having said that that MR seems to be going nowhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Podman integration brings support for multiple Unit types, including Kube unit that allows to start a pod with a YAML file declaration.
This PR in its current form is an RFC to discuss if these Unit Types are in the scope of this module. Or if they should be added to another module.