fix regex and test error #554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 11, 2024
lib/puppet/provider/cs_clone/pcs.rb
Outdated
| @@ -28,7 +28,7 @@ def change_clone_id(type, primitive, id, cib) | |||
| return unless doc.root.attributes['id'] != id | |||
|
|
|||
| doc.root.attributes['id'] = id | |||
| cmd = [command(:cibadmin), '--replace', '--xpath', xpath, '--xml-text', doc.to_s.chop] | |||
| cmd = [command(:cibadmin), '--replace', '--xpath', xpath, '--xml-text', doc.to_s] | |||
There was a problem hiding this comment.
which errors did that cause? Maybe this was meant to be chomp. not chop?
There was a problem hiding this comment.
i agree chomp is the best solution! i it was cutting in half a new line.
There was a problem hiding this comment.
oh you did find that also. wasn't aware of it
bastelfreak
reviewed
Oct 11, 2024
spec/classes/corosync_spec.rb
Outdated
| @@ -65,16 +59,16 @@ | |||
|
|
|||
| it 'configures votequorum' do | |||
| is_expected.to contain_file('/etc/corosync/corosync.conf').with_content( | |||
| %r{nodelist} | |||
| %r{nodelist\s*\{} | |||
There was a problem hiding this comment.
I'm wondering if those additional regular expressions provide any value? Do you think the original tests weren't sufficient enough, or did they cause problems?
There was a problem hiding this comment.
not really add value, just checking whole line.
added 4 commits
October 14, 2024 09:02
Removed typing error "$"char
Removed typing error "$"char chop -> chomp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This should fix the automatic test regex. and the cutted char in the config
This Pull Request (PR) fixes the following issues
#536