Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy facts from spec files and README #548

Merged
merged 3 commits into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ providers).
```puppet
class { 'corosync':
authkey => '/var/lib/puppet/ssl/certs/ca.pem',
bind_address => $::ipaddress,
bind_address => $facts['networking']['ip'],
cluster_name => 'mycluster',
enable_secauth => true,
}
Expand Down
4 changes: 2 additions & 2 deletions spec/acceptance/cs_order_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class { 'corosync':
end
end

if fact('osfamily') == 'RedHat'
if fact('os.family') == 'RedHat'
it 'creates a simple order constraint with Mandatory as kind' do
shell('cibadmin --query | grep first_then_two') do |r|
expect(r.stdout).to match(%r{kind="Mandatory"})
Expand Down Expand Up @@ -165,7 +165,7 @@ class { 'corosync':
end
end

if fact('osfamily') == 'RedHat'
if fact('os.family') == 'RedHat'
it 'creates a more complex order constraint with Optional as kind' do
shell('cibadmin --query | grep one_then_two_complex') do |r|
expect(r.stdout).to match(%r{kind="Optional"})
Expand Down
2 changes: 1 addition & 1 deletion spec/acceptance/cs_primitive_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ class { 'corosync':
},
}
EOS
if fact('osfamily') == 'RedHat'
if fact('os.family') == 'RedHat'
apply_manifest(pp, catch_failures: true, debug: false, trace: true)
apply_manifest(pp, catch_changes: true, debug: false, trace: true)
shell('pcs stonith show') do |r|
Expand Down
2 changes: 1 addition & 1 deletion spec/acceptance/cs_rsc_defaults_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper_acceptance'

describe 'corosync' do
if fact('osfamily') == 'Debian'
if fact('os.family') == 'Debian'
cert = '-----BEGIN CERTIFICATE-----
MIIDVzCCAj+gAwIBAgIJAJNCo5ZPmKegMA0GCSqGSIb3DQEBBQUAMEIxCzAJBgNV
BAYTAlhYMRUwEwYDVQQHDAxEZWZhdWx0IENpdHkxHDAaBgNVBAoME0RlZmF1bHQg
Expand Down
Loading