Pacemaker Fact & corosync.conf enhancement #535
+232
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new cluster fact for corosync environment details. Currently this is limited to extracting the version of PCS installed on the current machine so that it can be used to control behavior in other code.
This causes the pcsd authentication commands to be determined based on the new corosync facts instead of the original hiera based logic. Not a significant change, however, it is important for environments where the corosync class is declared instead of being included.
When the member list is names, not IP addresses, and the member name array is empty use the former to populate the name: in the nodelist. This addresses a parsing issue in `pcs cluster config` described in the redhat article below. It also ensures other commands that depend on the config file work as expected. https://access.redhat.com/solutions/6992919
pdemonaco
force-pushed
the
pcs_auth_provider
branch
from
b34f2ec
to
2277369
Compare
Hiera defaults were missing for the 10 and 11 versions of Debian causing a portion of the unit tests to fail. This tweak corrects that behavior by adding the definitions which subseqently allow qdevice to compile as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Two core changes:
corosyncto determine the version of pcspcs cluster config