-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation components to cart/checkout, add redemption #5
Open
weronika-kurczyna
wants to merge
50
commits into
feat/cart-persistance
Choose a base branch
from
wk/commerce-wrapper-add-redemption
base: feat/cart-persistance
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add validation components to cart/checkout, add redemption #5
weronika-kurczyna
wants to merge
50
commits into
feat/cart-persistance
from
wk/commerce-wrapper-add-redemption
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- show discount per voucher/promotions - some styling
weronika-kurczyna
changed the title
Add validation components, add redemption
Add validation components to cart/checkout, add redemption
Nov 14, 2023
marcin-slezak
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss the consistency in UI components (drawer vs cart summary vs order summary):
- order of presented information
- cart compontent:
subtotal
,delivery
,taxes
,order total
,promotions
,coupons
,all discounts
,grand total
- drawer component:
promotions
,coupons
,subtotal
,taxes
,delivery
,estimated total
,all discounts
,grand total
- order page:
promotions
,coupons
,subtotal
,delivery
,taxes
,all discounts
,grand total
- cart compontent:
- mixed naming:
estimated total
vsorder total
vsgrand total
- where we put horizontal line
- promotions badges are not visible on drawer component and order pages
- spacing looks bad between promotions, coupons on drawer and order pages
composable-ui/src/components/cart/cart-drawer/cart-drawer-footer.tsx
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added information about applied promotions, coupons and grand price to
cart-drawer-summary
,order-summary
Added information about all discounts to
bag-summary-mobile
(mobile version of checkout)Created a new commerce-wrapper for
create-order
so that the order has information about discounts and reduced priceIf it exists, send to Stripe
grandPrice
, then usetotalPrice
Fixed some typos in functions/files naming
Added stackable redemption to checkout
Prevent values from being reset when an invalid coupon has been used, do not allow adding an invalid coupon to cart
In progress
(another branch: wk/commerce-wrapper-unit-discount)
Next steps
pnpm jest --ci --coverage --coverageReporters json-summary
Bugs