Add Eastron SDM54 #352
Merged
Add Eastron SDM54 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
reviewed
Nov 29, 2024
| * This is to a large extent a superset of all SDM devices, however there are | ||
| * subtle differences (see 220, 230). Some opcodes might not work on some devices. | ||
| */ | ||
| ops := Opcodes{ |
There was a problem hiding this comment.
Please gofmt the code (or use VScode with Go plugin)
There was a problem hiding this comment.
Thanks for your comment, I have done that. As this is my first time adapting go code I would need some support: I have really no clue why the porcelain test fails. Could you please help me out?
There was a problem hiding this comment.
OK, I figured it out. Is there anything else?
|
Great PR, thank you 👍🏻 |
|
thanks a lot, it is my first PR ever on github. MBMD and volkszaehler are great projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding new meter SDM54; adding entries in README and help for that meter