Run tests against multiple versions in CI #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pr. I’ll take a look at the CI.
…On Mon, Nov 8, 2021 at 9:28 PM Luke Albao ***@***.***> wrote:
Hi, thanks for creating this package. It looks really promising for my use
case. I'm working on adding some tests so that we can land #5
<#5> and I see that CI
doesn't appear to be fully functional AFAICT.
Here's
<https://github.com/lukealbao/postgres-rrule/actions/runs/1437631123> the
matrix run I did on my fork, where I found that the tests break against
PG10 (haven't investigated what the problem is). Hopefully, this is still
maintained and I'll open a separate PR for the tests requested in #5
<#5>.
------------------------------
You can view, comment on, or merge this pull request online at:
#16
Commit Summary
- Run tests against multiple versions in CI
<0b3a74e>
File Changes
(3 files <https://github.com/volkanunsal/postgres-rrule/pull/16/files>)
- *D* .github/run-tests.sh
<https://github.com/volkanunsal/postgres-rrule/pull/16/files#diff-1034d510bea368a495e2cd9082d28b173db8af7045d638f781dedd270bbd4b66>
(2)
- *M* .github/workflows/pull_request.yml
<https://github.com/volkanunsal/postgres-rrule/pull/16/files#diff-a0fe23534b616d51ce686d2a1bcd1a78bc75074aef1a2f6ee96c9469991e1a4c>
(58)
- *M* Makefile
<https://github.com/volkanunsal/postgres-rrule/pull/16/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52>
(9)
Patch Links:
- https://github.com/volkanunsal/postgres-rrule/pull/16.patch
- https://github.com/volkanunsal/postgres-rrule/pull/16.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFAME7EJJQCSDJDRDJNXLULCBLBANCNFSM5HUFFMVQ>
.
|
volkanunsal
approved these changes
Nov 9, 2021
|
Looks like you're right about the failing tests. I'll try to debug the tests this week. |
|
@lukealbao Tests have been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for creating this package. It looks really promising for my use case. I'm working on adding some tests so that we can land #5 and I see that CI doesn't appear to be fully functional AFAICT.
Here's the matrix run I did on my fork, where I found that the tests break against PG10 (haven't investigated what the problem is). Hopefully, this is still maintained and I'll open a separate PR for the tests requested in #5.