Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/waypoint (WIP) #15

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Feature/waypoint (WIP) #15

wants to merge 18 commits into from

Conversation

FredericGuilbault
Copy link

@FredericGuilbault FredericGuilbault commented Apr 17, 2018

This feature add the capability to set a waypoint on the map and use 4 instruments related to it
Velocity made good, estimated time arrival, Distance to waypoint and Bering to waypoint.

Althrough this feature is usable, Some things left to be done/fixed.

  • Avoid the use of a global variable
  • New Instruments refresh rate is one refresh behind others instruments.
  • Eta display is too large for the instrument panel (should be h:mm instead of hh:mm:ss)

-- Edit:

  • I added prettier and eslint to enforce code style, please update the PR with those
  • Instead of computing distances and bearings yourself, please use the capabilities provided by geolib or the Leaflet. Both are already used in the app.

... and probably more (feel free to add).

Help is welcome :D

@vokkim
Copy link
Owner

vokkim commented Apr 19, 2018

Few comments:

  • I added prettier and eslint to enforce code style, please update the PR with those
  • Instead of computing distances and bearings yourself, please use the capabilities provided by geolib or the Leaflet. Both are already used in the app.

@FredericGuilbault
Copy link
Author

"Instead of computing distances and bearings yourself, please use the capabilities provided by geolib or the Leaflet. Both are already used in the app."

is Fixed In commits 9ebfd20 & bbe4ec0

@FredericGuilbault
Copy link
Author

FredericGuilbault commented Jun 21, 2018

I added prettier and eslint to enforce code style, please update the PR with those

is Fixed in commit c4e60a8
npm run test dosen't report any errors :D

I also merged 1b2a60c to stay up to date with master branch

@FredericGuilbault
Copy link
Author

FredericGuilbault commented Jun 22, 2018

Avoid the use of a global variable

is Fixed in commit 056901e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants