-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: when a widget fails, show a fallback error widget #667
feat: when a widget fails, show a fallback error widget #667
Conversation
9187a37
to
75d7c70
Compare
cc @jasongrout |
Me might want to have a troubleshoot link in the message. Maybe we should then also have a troubleshoot page at ipywidgets? Another thing we should consider, is add two methods to the widget manager:
Since now we do not know when a Model or View needs to be loaded, we cannot create a fallback Model or View. |
75d7c70
to
5b43717
Compare
Code is simplified a bit (force pushed) |
5b43717
to
85fd9d9
Compare
@SylvainCorlay I think we can merge this, the failure on Travis seems a fluke, and we cannot restart it 🤷 We might want to consider upstreaming this to core jupyter-widgets (working on it), but I think that will take a while. |
85fd9d9
to
95a63e0
Compare
@maartenbreddels I just rebased your PR and translated the code to AnyScript so that it works with the new typescript codebase. |
95a63e0
to
a4dff1f
Compare
a4dff1f
to
81706ce
Compare
Hi @maartenbreddels, I'm working on testing Voila with different types of bugged widgets (#985) so I tried your PR and it works nicely. I think it will be super useful if it can be merged. |
I think it would be better to work on the upstream version of this jupyter-widgets/ipywidgets#2960 |
If we're fast enough, we can maybe squeeze it in ipywidgets 8.0 |
Indeed, it missed that part, I will try to push it into 8.0 |
That would be great! |
This feature is added in |
Fixes #657
Consider this code:
This would now render to:
If the semver is off:
You'd see this:
And if the widget model name is off:
It renders:
So in all of these cases, something gets rendered. The only case that is not handled, is when the view_name is off (difficult to catch)