Merge pull request #1048 from martinRenou/update_screenshots

UI-tests: Update ipympl screenshots
voila-dashboards · Dec 21, 2021 · 63a81d1 · 63a81d1
2 parents 41ad079 + 62d6c4b
commit 63a81d1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml
@@ -19,7 +19,7 @@ jobs:
 
       - name: Install dependencies
         run: |
-          python -m pip install --upgrade jupyterlab~=3.0 numpy bqplot matplotlib ipympl==0.8.0 ipyvolume scipy
+          python -m pip install --upgrade jupyterlab~=3.0 numpy bqplot matplotlib ipympl ipyvolume scipy
           python -m pip install ".[test]"
           jlpm
           jlpm build

diff --git a/ui-tests/tests/voila.test.ts b/ui-tests/tests/voila.test.ts
@@ -105,9 +105,7 @@ test.describe('Voila performance Tests', () => {
     const notebookName = 'ipympl';
     const testFunction = async () => {
       await page.goto(`render/${notebookName}.ipynb`);
-      await page.waitForSelector(
-        'div.jupyter-widgets.jupyter-matplotlib-canvas-container canvas'
-      );
+      await page.waitForSelector('div.jupyter-matplotlib-figure');
     };
     await addBenchmarkToTest(notebookName, testFunction, testInfo, browserName);
     expect(await page.screenshot()).toMatchSnapshot(`${notebookName}.png`);

diff --git a/ui-tests/tests/voila.test.ts-snapshots/ipympl-linux.png b/ui-tests/tests/voila.test.ts-snapshots/ipympl-linux.png