[dpi,aes] Allow partial last message blocks for AES-GCM #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
reviewed
Nov 15, 2024
| if (impl == 0) { | ||
| // The C model is currently not supported. | ||
| printf( | ||
| "ERROR: c_dpi_aes_crypt_message() currently supports OpenSSL/BoringSSL " | ||
| "only\n"); | ||
| } else { // OpenSSL/BoringSSL | ||
| if (!op) { | ||
| crypto_encrypt(ref_out, iv, ref_in, data_len, key, key_len, mode, aad_in, | ||
| crypto_encrypt(ref_out, iv, ref_in, data_len, key, key_len, kCryptoAesGcm, aad_in, |
There was a problem hiding this comment.
Is this change intentional?
There was a problem hiding this comment.
Nice catch. Thank you. :-)
vogelpi
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
This looks good to me except for the point raised by @nasahlpa . Thanks for the PR @andrea-caforio !
|
Also, it currently fails lint. Can you please do a |
Unlike the existing AES modes, the new GCM mode allows for partial last message blocks. This commit adds this option to the `c_dpi` implementation, i.e., the automatic padding of partial blocks. Signed-off-by: Andrea Caforio <[email protected]>
andrea-caforio
force-pushed
the
c-dpi-aes-gcm-partial-blocks
branch
from
d90e6d0 to
ab6695e
Compare
nasahlpa
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the existing AES modes, the new GCM mode allows for partial last message blocks.
This commit adds this option to the
c_dpiimplementation, i.e., the automatic padding ofpartial blocks.