vocone: refactor Vocone struct as an extension of service.VocdoniService

[altergui]

this way, the whole init phase is much similar to what node does, avoiding bugs
and making it easier to maintain in the future when features are added

this refactor was originated by a bug introduced when OffchainDataDownloader feature
was merged on node but not fully properly in voconed,
so voconed was not doing vs.DataDownloader.Start() that node does during init

the best solution was to make voconed call the same init function that node calls
srv.OffChainDataHandler()

[altergui]

i'm pushing this trivial fix, so that it can be used (or tested) already.

but i'd not merge this PR as-is, i'll try first to make a nicer refactor of voconed init and push that instead

[coveralls]

Pull Request Test Coverage Report for Build 6403401623

• 55 of 67 (82.09%) changed or added relevant lines in 3 files are covered.
• 12 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.003%) to 57.759%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
vocone/vocone.go	52	64	81.25%

Files with Coverage Reduction	New Missed Lines	%
vocone/vocone.go	12	61.64%

Totals
Change from base Build 6379751065:	-0.003%
Covered Lines:	12625
Relevant Lines:	21858

---

💛 - Coveralls

[altergui]

there you go, nicer refactor of voconed, that as a side effect fixes #1126 and prevents future issues like this when features are implemented

[altergui]

i need to fix TestVocone but it's probably something trivial,
the PR can still be reviewed as is

i also thought of replacing that TestVocone with an actual integration test, since voconed binary (and docker image) is totally untested (and this created problems in the past for vocdoni-sdk CI)

[lucasmenendez]

there you go, nicer refactor of voconed, that as a side effect fixes #1126 and prevents future issues like this when features are implemented

I was testing with this branch with two different tokens:

• 0xBFAbdE619ed5C4311811cF422562709710DB587d (mainnet) -> ipfs://bafybeiehw3bldmap6buiscwbsys3bdcahpqt2xzugieu6ai2yq4ohijghq
• 0xF530280176385AF31177D78BbFD5eA3f6D07488A (goerli) -> ipfs://bafybeiezzvgxwv6nykjkbcmqfd55g7smpilvj7nedx2crynyhtp2u2tx5a

And for me, the problem continues 🙁. The file is in the downloader queue but the census is not created.

[altergui]

thanks for the report,
i'd say it's related to the error that also happens in TestVocone

      e"missing modules attached for enabling handler censuses"

i'm looking into it

[p4u]

Makes sense, thx

[lucasmenendez]

The changes are OK for me, but testing the latest version it still fails to download censuses from IPFS, even with the same IPFS connect key in both services (census3 and vocone).