Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth and icons #895

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

auth and icons #895

wants to merge 4 commits into from

Conversation

gerouvi
Copy link
Collaborator

@gerouvi gerouvi commented Dec 23, 2024

  • Clients Logos

  • Signin

  • The general form should be vertically centered in the middle (IMG1)
  • When I have an error, if I go back and enter again, the error is still there, we should remove it.
  • The "Mantenerme conectado" checkbox does noting
  • Unify the size of "¿Aú no estás registrado?" vs "Crear una cuenta". Different font size.
  • The "Crear una cuenta" should be a link
  • The "Soporte", "Condiciones...", "Blog" should have a more contrasted color.
  • The "Condiciones de uso" should open in a new tab (same as blog or soporte).
  • The right side doesn't look good in certain sizes (responsive).
  • Signup
  • The register title is not good, it says "Iniciar sesión" instead of Register. Same wih description.
    Same than "SignIn Page":
  • The general form should be vertically centered in the middle (IMG1)
  • The "Crear una cuenta implica..." checkbox does noting
  • Unify the size of "¿Ya eres miembro?" vs "Iniciar Sesión". Different font size.
  • The "Crear una cuenta" should be a link
  • The "Soporte", "Condiciones...", "Blog" should have a more contrasted color.
  • The "Condiciones de uso" should open in a new tab (same as blog or soporte).
  • The right side doesn't look good in certain sizes (responsive). Img: 2
  • The form error color seems to not be working, when I try to submit the form without any information, only blue color appear instead of red.
  • Create your organizations
  • The "Descrption" textarea background should be the same color as inputs.
  • The form width should be wider (maybe max-width 650px when desktop?) is weird to have the form so small and having 2 text lines in a lot of them

related #894

@gerouvi gerouvi requested a review from elboletaire December 23, 2024 19:26
Copy link

@github-actions github-actions bot temporarily deployed to pull request December 23, 2024 19:27 Inactive
Copy link

@github-actions github-actions bot temporarily deployed to pull request December 23, 2024 19:27 Inactive
const methods = useForm<FormData>({
defaultValues: { email: emailProp },
})
const [isErrorA, setIsErrorA] = useState(false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? What are you trying with this state? Also, terrible naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants