Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: paginated list results on API endpoints #100

Merged
merged 12 commits into from
Nov 6, 2023
Merged

feature: paginated list results on API endpoints #100

merged 12 commits into from
Nov 6, 2023

Conversation

lucasmenendez
Copy link
Collaborator

solving #99

Implement some pagination strategy over large list results on API endpoints.
GET /tokens
GET /strategies
It is also needed for future endpoints, such as:
GET /tokens/{token_address}/holders
GET /censuses

@lucasmenendez lucasmenendez self-assigned this Oct 9, 2023
@lucasmenendez lucasmenendez linked an issue Oct 9, 2023 that may be closed by this pull request
feature: paginated list results on API endpoints #99
Closed
@lucasmenendez lucasmenendez mentioned this pull request Oct 9, 2023
Closed
mvdan
mvdan reviewed Oct 9, 2023
View reviewed changes
api/tokens.go Outdated Show resolved Hide resolved
@lucasmenendez lucasmenendez force-pushed the feature/paginated_api_results branch from fe8276d to 979a5e6 Compare October 19, 2023 12:26
@lucasmenendez lucasmenendez marked this pull request as ready for review October 19, 2023 15:59
@lucasmenendez
Copy link
Collaborator Author

@jordipainan if you are agree i will merge this today to deploy it to dev

@lucasmenendez lucasmenendez mentioned this pull request Nov 6, 2023
Merged
jordipainan
jordipainan approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@jordipainan jordipainan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but reduce page size to 10. Strategies are not that big and dealing with 100 tokens at the same page is unnecessary. Thank you for the work :)

@lucasmenendez lucasmenendez merged commit 81122a1 into main Nov 6, 2023
6 checks passed
@lucasmenendez lucasmenendez deleted the feature/paginated_api_results branch November 6, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan left review comments

@jordipainan jordipainan jordipainan approved these changes

@marcvelmer marcvelmer Awaiting requested review from marcvelmer

Assignees

@lucasmenendez lucasmenendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: paginated list results on API endpoints
3 participants
@lucasmenendez @mvdan @jordipainan