get a new client in every attempt to check if the web3 endpoint suppo…

…rt CodeAt, increase the number of retries to get the token creation block

docker-compose.yml

@@ -2,7 +2,7 @@ version: "3.7"
 
 services:
   census3:
-    image: ghcr.io/vocdoni/census3:main
+    image: ghcr.io/vocdoni/census3:aragon
     build: .
     env_file: ".env"
     restart: always

scanner/providers/gitcoin/gitcoin_provider_test.go

@@ -42,7 +42,7 @@ func TestGitcoinPassport(t *testing.T) {
 	})
 	// create the provider
 	provider := new(GitcoinPassport)
-	c.Assert(provider.Init(ctx, GitcoinPassportConf{endpoints["/original"], time.Second * 2, testDB}), qt.IsNil)
+	c.Assert(provider.Init(ctx, GitcoinPassportConf{endpoints["/original"], time.Second, testDB}), qt.IsNil)
 	// start the first download
 	emptyBalances, _, _, _, _, err := provider.HoldersBalances(context.TODO(), nil, 0)
 	c.Assert(err, qt.IsNil)

scanner/providers/web3/const.go

@@ -3,7 +3,7 @@ package web3
 import "time"
 
 const (
-	DefaultMaxWeb3ClientRetries = 3
+	DefaultMaxWeb3ClientRetries = 5
 	RetryWeb3Cooldown           = 500 * time.Millisecond
 )
 

scanner/providers/web3/web3_provider.go

@@ -35,12 +35,12 @@ func creationBlock(client *Client, ctx context.Context, addr common.Address) (ui
 	// check if the current client supports `eth_getCode` method, if not, return
 	// 1 and nil. It is assumed that the contract is created at block 1 to start
 	// scanning from the first block.
-	ethClient, err := client.EthClient()
-	if err != nil {
-		return 0, err
-	}
 	getCodeSupport := false
 	for i := 0; i < DefaultMaxWeb3ClientRetries; i++ {
+		ethClient, err := client.EthClient()
+		if err != nil {
+			return 0, err
+		}
 		if getCodeSupport = providers.ClientSupportsGetCode(ctx, ethClient, addr); getCodeSupport {
 			break
 		}
@@ -50,6 +50,7 @@ func creationBlock(client *Client, ctx context.Context, addr common.Address) (ui
 		return 1, nil
 	}
 	// get the latest block number
+	var err error
 	var lastBlock uint64
 	for i := 0; i < DefaultMaxWeb3ClientRetries; i++ {
 		lastBlock, err = client.BlockNumber(ctx)