fixes about http request contexts, missing db tx rollback and verbose…

… slice contains code

api/censuses.go

@@ -44,7 +44,7 @@ func (capi *census3API) getCensus(msg *api.APIdata, ctx *httprouter.HTTPContext)
 		return ErrMalformedCensusID
 	}
 	censusID := uint64(iCensusID)
-	internalCtx, cancel := context.WithTimeout(context.Background(), getCensusTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), getCensusTimeout)
 	defer cancel()
 	currentCensus, err := capi.db.QueriesRO.CensusByID(internalCtx, censusID)
 	if err != nil {
@@ -129,7 +129,7 @@ func (capi *census3API) createAndPublishCensus(req *CreateCensusRequest, qID str
 
 	strategy, err := qtx.StrategyByID(internalCtx, req.StrategyID)
 	if err != nil {
-		if errors.Is(sql.ErrNoRows, err) {
+		if errors.Is(err, sql.ErrNoRows) {
 			return 0, ErrNotFoundStrategy.WithErr(err)
 		}
 		return 0, ErrCantCreateCensus.WithErr(err)
@@ -152,7 +152,7 @@ func (capi *census3API) createAndPublishCensus(req *CreateCensusRequest, qID str
 		// get the strategy holders from the database
 		holders, err := qtx.TokenHoldersByStrategyID(internalCtx, req.StrategyID)
 		if err != nil {
-			if errors.Is(sql.ErrNoRows, err) {
+			if errors.Is(err, sql.ErrNoRows) {
 				return 0, ErrNoStrategyHolders.WithErr(err)
 			}
 			return 0, ErrCantCreateCensus.WithErr(err)
@@ -170,7 +170,7 @@ func (capi *census3API) createAndPublishCensus(req *CreateCensusRequest, qID str
 		// get strategy tokens from the database
 		strategyTokens, err := qtx.TokensByStrategyID(internalCtx, req.StrategyID)
 		if err != nil {
-			if errors.Is(sql.ErrNoRows, err) {
+			if errors.Is(err, sql.ErrNoRows) {
 				return 0, ErrNoStrategyTokens.WithErr(err)
 			}
 			return 0, ErrCantCreateCensus.WithErr(err)
@@ -208,7 +208,7 @@ func (capi *census3API) createAndPublishCensus(req *CreateCensusRequest, qID str
 	// check if the census already exists
 	_, err = qtx.CensusByID(internalCtx, newCensusID)
 	if err != nil {
-		if !errors.Is(sql.ErrNoRows, err) {
+		if !errors.Is(err, sql.ErrNoRows) {
 			return 0, ErrCantCreateCensus.WithErr(err)
 		}
 	} else {
@@ -282,7 +282,7 @@ func (capi *census3API) enqueueCensus(msg *api.APIdata, ctx *httprouter.HTTPCont
 	// check if it is not finished or some error occurred
 	if done && err == nil {
 		// if everything is ok, get the census information an return it
-		internalCtx, cancel := context.WithTimeout(context.Background(), enqueueCensusCreationTimeout)
+		internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), enqueueCensusCreationTimeout)
 		defer cancel()
 		censusID, ok := data["censusID"].(uint64)
 		if !ok {
@@ -332,7 +332,7 @@ func (capi *census3API) getStrategyCensuses(msg *api.APIdata, ctx *httprouter.HT
 		return ErrMalformedCensusID.WithErr(err)
 	}
 	// get censuses by this strategy ID
-	internalCtx, cancel := context.WithTimeout(context.Background(), getStrategyCensusesTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), getStrategyCensusesTimeout)
 	defer cancel()
 	rows, err := capi.db.QueriesRO.CensusByStrategyID(internalCtx, uint64(strategyID))
 	if err != nil {

api/strategies.go

@@ -49,13 +49,18 @@ func (capi *census3API) initStrategiesHandlers() error {
 // the database. It returns a 204 response if any strategy is registered or a
 // 500 error if something fails.
 func (capi *census3API) getStrategies(msg *api.APIdata, ctx *httprouter.HTTPContext) error {
-	internalCtx, cancel := context.WithTimeout(context.Background(), getStrategiesTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), getStrategiesTimeout)
 	defer cancel()
 	// create db transaction
 	tx, err := capi.db.RO.BeginTx(internalCtx, nil)
 	if err != nil {
 		return ErrCantGetStrategies.WithErr(err)
 	}
+	defer func() {
+		if err := tx.Rollback(); err != nil && !errors.Is(sql.ErrTxDone, err) {
+			log.Errorw(err, "get strategies transaction rollback failed")
+		}
+	}()
 	qtx := capi.db.QueriesRO.WithTx(tx)
 	// get strategies associated to the token provided
 	rows, err := qtx.ListStrategies(internalCtx)
@@ -98,7 +103,7 @@ func (capi *census3API) getStrategies(msg *api.APIdata, ctx *httprouter.HTTPCont
 }
 
 func (capi *census3API) createStrategy(msg *api.APIdata, ctx *httprouter.HTTPContext) error {
-	internalCtx, cancel := context.WithTimeout(context.Background(), createDummyStrategyTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), createDummyStrategyTimeout)
 	defer cancel()
 
 	req := CreateStrategyRequest{}
@@ -195,7 +200,7 @@ func (capi *census3API) getStrategy(msg *api.APIdata, ctx *httprouter.HTTPContex
 	}
 	strategyID := uint64(iStrategyID)
 	// get strategy from the database
-	internalCtx, cancel := context.WithTimeout(context.Background(), getStrategyTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), getStrategyTimeout)
 	defer cancel()
 	strategyData, err := capi.db.QueriesRO.StrategyByID(internalCtx, strategyID)
 	if err != nil {
@@ -236,7 +241,7 @@ func (capi *census3API) getStrategy(msg *api.APIdata, ctx *httprouter.HTTPContex
 // if the provided ID is wrong or empty, a 204 response if the token has not any
 // associated strategy or a 500 error if something fails.
 func (capi *census3API) getTokenStrategies(msg *api.APIdata, ctx *httprouter.HTTPContext) error {
-	internalCtx, cancel := context.WithTimeout(context.Background(), getTokensStrategyTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), getTokensStrategyTimeout)
 	defer cancel()
 	// get the tokenID provided
 	tokenID := ctx.URLParam("tokenID")

api/tokens.go

@@ -44,7 +44,7 @@ func (capi *census3API) initTokenHandlers() error {
 // database. It returns a 204 response if no tokens are registered or a 500
 // error if something fails.
 func (capi *census3API) getTokens(msg *api.APIdata, ctx *httprouter.HTTPContext) error {
-	internalCtx, cancel := context.WithTimeout(context.Background(), getTokensTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), getTokensTimeout)
 	defer cancel()
 	// TODO: Support for pagination
 	// get tokens from the database
@@ -95,7 +95,7 @@ func (capi *census3API) createToken(msg *api.APIdata, ctx *httprouter.HTTPContex
 	// init web3 client to get the token information before register in the
 	// database
 	w3 := state.Web3{}
-	internalCtx, cancel := context.WithTimeout(context.Background(), createTokenTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), createTokenTimeout)
 	defer cancel()
 	// get correct web3 uri provider
 	w3URI, exists := capi.w3p.URIByChainID(req.ChainID)
@@ -193,7 +193,7 @@ func (capi *census3API) createToken(msg *api.APIdata, ctx *httprouter.HTTPContex
 // fails.
 func (capi *census3API) getToken(msg *api.APIdata, ctx *httprouter.HTTPContext) error {
 	address := common.HexToAddress(ctx.URLParam("tokenID"))
-	internalCtx, cancel := context.WithTimeout(context.Background(), getTokenTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), getTokenTimeout)
 	defer cancel()
 	tokenData, err := capi.db.QueriesRO.TokenByID(internalCtx, address.Bytes())
 	if err != nil {
@@ -283,7 +283,7 @@ func (capi *census3API) isTokenHolder(msg *api.APIdata, ctx *httprouter.HTTPCont
 	if err != nil {
 		return ErrMalformedChainID.WithErr(err)
 	}
-	internalCtx, cancel := context.WithTimeout(context.Background(), getTokenTimeout)
+	internalCtx, cancel := context.WithTimeout(ctx.Request.Context(), getTokenTimeout)
 	defer cancel()
 
 	exists, err := capi.db.QueriesRO.ExistTokenHolder(internalCtx, queries.ExistTokenHolderParams{

lexer/example_test.go

@@ -2,6 +2,7 @@ package lexer
 
 import (
 	"fmt"
+	"slices"
 	"sort"
 )
 
@@ -62,14 +63,7 @@ func AND(iter *Iteration[[]string]) ([]string, error) {
 
 	res := []string{}
 	for _, a := range dataA {
-		exist := false
-		for _, b := range dataB {
-			if a == b {
-				exist = true
-				break
-			}
-		}
-		if exist {
+		if slices.Contains(dataB, a) {
 			res = append(res, a)
 		}
 	}

lexer/lexer.go

@@ -1,6 +1,9 @@
 package lexer
 
-import "fmt"
+import (
+	"fmt"
+	"slices"
+)
 
 // Lexer struct helps to parse a predicated with a predefined operators,
 // generating a iterable struct to eval the it then.
@@ -16,12 +19,7 @@ func NewLexer(ops []string) *Lexer {
 // SupportedOperator method return if the tag provided is a operator supported
 // by the current lexer
 func (l *Lexer) SupportedOperator(tag string) bool {
-	for _, op := range l.ops {
-		if op == tag {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(l.ops, tag)
 }
 
 // Parse method tokenize the predicate provided a decode its groups levels

lexer/token.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"math/rand"
+	"slices"
 	"strings"
 )
 
@@ -94,14 +95,7 @@ func (t *Token) AllLiterals() []string {
 	}
 	res := []string{}
 	commit := func(i string) {
-		exists := false
-		for _, r := range res {
-			if r == i {
-				exists = true
-				break
-			}
-		}
-		if !exists {
+		if !slices.Contains(res, i) {
 			res = append(res, i)
 		}
 	}