[feat][enhance] enhance error handler for api get token

vngcloud · May 22, 2024 · 303c46f · 303c46f
1 parent 3680fa6
commit 303c46f
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/vngcloud/sdk_error/error_codes.go b/vngcloud/sdk_error/error_codes.go
@@ -19,6 +19,7 @@ const (
 const (
 	EcAuthenticationFailed = ErrorCode("VngCloudIamAuthenticationFailed")
 	EcTooManyFailedLogins  = ErrorCode("VngCloudIamTooManyFailedLogins")
+	EcUnknownAuthFailure   = ErrorCode("VngCloudIamUnknownAuthFailure")
 )
 
 // VServer secgroup

diff --git a/vngcloud/sdk_error/identity.go b/vngcloud/sdk_error/identity.go
@@ -47,3 +47,21 @@ func WithErrorTooManyFailedLogin(perrResp IErrorRespone) func(ISdkError) {
 		}
 	}
 }
+
+func WithErrorUnknownAuthFailure(perrResp IErrorRespone) func(ISdkError) {
+	return func(sdkErr ISdkError) {
+		if perrResp == nil {
+			return
+		}
+
+		if perrResp.GetError() == nil {
+			return
+		}
+
+		if sdkErr.GetErrorCode() == EcUnknownError {
+			sdkErr.WithErrorCode(EcUnknownAuthFailure).
+				WithMessage(perrResp.GetMessage()).
+				WithErrors(perrResp.GetError())
+		}
+	}
+}
diff --git a/vngcloud/services/identity/v2/identity.go b/vngcloud/services/identity/v2/identity.go
@@ -24,7 +24,9 @@ func (s *IdentityServiceV2) GetAccessToken(popts IGetAccessTokenRequest) (*lsent
 	if _, sdkErr := s.IamClient.Post(url, req); sdkErr != nil {
 		return nil, lserr.SdkErrorHandler(sdkErr, errResp,
 			lserr.WithErrorTooManyFailedLogin(errResp),
-			lserr.WithErrorAuthenticationFailed(errResp)).WithKVparameters("clientId", popts.GetClientId())
+			lserr.WithErrorAuthenticationFailed(errResp),
+			lserr.WithErrorUnknownAuthFailure(errResp)). // Always put this handler at the end
+			WithKVparameters("clientId", popts.GetClientId())
 	}
 
 	return resp.ToEntityAccessToken(), nil