fix: required argument and wait resources are deleted when uninstalli…

…ng chart release
vngcloud · Aug 28, 2023 · 1601f40 · 1601f40
1 parent 13be957
commit 1601f40
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/charts/vmonitor-metric-agent/CHANGELOG.md b/charts/vmonitor-metric-agent/CHANGELOG.md
@@ -0,0 +1,6 @@
+# vMonitor Platform Metric Agent changelog
+
+## 0.3.0
+
+* Fix `clusterrole` not being removed when uninstalling chart release
+* Fix `required argument` when upgrading chart release
diff --git a/charts/vmonitor-metric-agent/Chart.yaml b/charts/vmonitor-metric-agent/Chart.yaml
@@ -15,5 +15,5 @@ dependencies:
   name: kube-state-metrics
   repository: https://prometheus-community.github.io/helm-charts
   version: 4.20.0
-version: 0.2.0
+version: 0.3.0
 appVersion: "1.26.2"
diff --git a/charts/vmonitor-metric-agent/README.md b/charts/vmonitor-metric-agent/README.md
@@ -61,7 +61,7 @@ kubectl get pod <-n your_namespace> | grep "vmonitor-metric-agent"
 To uninstall/delete the `vmonitor-metric-agent` deployment:
 
 ```bash
-helm uninstall vmonitor-metric-agent
+helm uninstall vmonitor-metric-agent --wait
 ```
 
 The command removes all the Kubernetes resources associated with the chart and deletes the release.

diff --git a/charts/vmonitor-metric-agent/templates/secret-vmonitor.yaml b/charts/vmonitor-metric-agent/templates/secret-vmonitor.yaml
@@ -8,7 +8,7 @@ metadata:
 type: Opaque
 data:
   CLUSTER_NAME: {{ default "cluter-k8s" .Values.vmonitor.clusterName | b64enc | quote }}
-  IAM_CLIENT_ID: {{ required "IAM_CLIENT_ID is required value!" .Values.vmonitor.iamClientID | b64enc | quote }}
-  IAM_CLIENT_SECRET: {{ required "IAM_CLIENT_SECRET is required value!" .Values.vmonitor.iamClientSecret | b64enc | quote }}
+  IAM_CLIENT_ID: {{ default "YOUR_IAM_CLIENT_ID" .Values.vmonitor.iamClientID | b64enc | quote }}
+  IAM_CLIENT_SECRET: {{ default "YOUR_IAM_CLIENT_SECRET" .Values.vmonitor.iamClientSecret | b64enc | quote }}
   VMONITOR_SITE: {{ default "monitoring-agent.vngcloud.vn" .Values.vmonitor.vmonitorSite | b64enc | quote }}
   IAM_URL: {{ default "https://iamapis.vngcloud.vn/accounts-api/v2/auth/token" .Values.vmonitor.iamURL | b64enc | quote }}