change the batch feature in l10n agent #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Dismissed
Show dismissed
Hide dismissed
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Fixed
Show fixed
Hide fixed
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2531 +/- ##
=========================================
Coverage 52.67% 52.67%
Complexity 391 391
=========================================
Files 68 68
Lines 2335 2335
Branches 288 288
=========================================
Hits 1230 1230
Misses 946 946
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Xiaochao8
reviewed
Aug 1, 2023
g11n-ws/vip-manager-l10n-agent/src/main/java/com/vmware/l10agent/model/KeySourceModel.java
Show resolved
Hide resolved
|
Where is the design doc? |
|
huihuiw01
reviewed
Aug 1, 2023
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Outdated
Show resolved
Hide resolved
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Outdated
Show resolved
Hide resolved
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Outdated
Show resolved
Hide resolved
huihuiw01
previously approved these changes
Aug 1, 2023
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Dismissed
Show dismissed
Hide dismissed
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Dismissed
Show dismissed
Hide dismissed
Xiaochao8
reviewed
Aug 2, 2023
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Outdated
Show resolved
Hide resolved
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Outdated
Show resolved
Hide resolved
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Outdated
Show resolved
Hide resolved
Xiaochao8
reviewed
Aug 2, 2023
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Show resolved
Hide resolved
tigershi
changed the title
huihuiw01
reviewed
Aug 3, 2023
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Show resolved
Hide resolved
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Show resolved
Hide resolved
huihuiw01
approved these changes
Aug 3, 2023
linr211
reviewed
Aug 3, 2023
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Show resolved
Hide resolved
linr211
reviewed
Aug 3, 2023
g11n-ws/vip-manager-l10n-agent/src/main/resources/application.properties
Show resolved
Hide resolved
I have sent the site in slack |
Xiaochao8
reviewed
Aug 9, 2023
...manager-l10n-agent/src/main/java/com/vmware/l10agent/service/SingleComponentServiceImpl.java
Show resolved
Hide resolved
Xiaochao8
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.