Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage: Create directory for mount if it doesn't exist #134

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

dtarasov7
Copy link
Contributor

@dtarasov7 dtarasov7 commented Jan 26, 2023

In function NodeStageVolume, before mount the device on a directory on the host, need check - if directory exist. And if it doesn't exist then create it.

Fixes this bug:
#132

Signed-off-by: dtarasov7 [email protected]


This change is Reviewable

@vmwclabot
Copy link
Member

@dtarasov7, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@dtarasov7, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@dtarasov7, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

“VMware is not able to accept your contribution at this time.”

@vmwclabot
Copy link
Member

@dtarasov7, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@dtarasov7, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

“VMware is not able to accept your contribution at this time.”

@vmwclabot
Copy link
Member

@dtarasov7, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@dtarasov7, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

“VMware is not able to accept your contribution at this time.”

@vmwclabot
Copy link
Member

@dtarasov7, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@arunmk arunmk requested review from arunmk and ymo24 February 5, 2023 20:49
Copy link
Contributor

@ymo24 ymo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arunmk)

@vmwclabot
Copy link
Member

@dtarasov7, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

VMware is not able to accept your contribution at this time

@Negashev
Copy link

Negashev commented Feb 9, 2023

This will fix if you change pv-dir

/var/lib/kubelet/plugins/kubernetes.io/csi/pv
to
/var/lib/kubelet/plugins/kubernetes.io/csi

@ymo24
Copy link
Contributor

ymo24 commented Feb 14, 2023

Hi, would you re-edit this PR and then fill the pull-request template? Please ensure to attach the testing screenshot.

Copy link
Collaborator

@arunmk arunmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dtarasov7)

@arunmk arunmk merged commit 6495ad4 into vmware:main Feb 20, 2023
@vmwclabot
Copy link
Member

@dtarasov7, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@dtarasov7, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants