🌱 Refactor chanErr creation & consumption for async create VM workflow #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/minor-async-refactor
branch
from
5da73b9 to
44f994f
Compare
github-actions
bot
added
size/L
bryanv
approved these changes
Dec 19, 2024
added 2 commits
December 19, 2024 11:23
This patch changes the way the error channel is created during the async create workflow to make this more explicit and reduces the chances someone does not close the channel.
This patch changes the way the error channel from the async create workflow is consumed in the VirtualMachine controller. Previously only a single error was assumed to be returned, but since this is a channel, the consumer should range over it, accounting for the possible vim and k8s error.
akutz
force-pushed
the
feature/minor-async-refactor
branch
from
44f994f to
bdfe8ab
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This PR includes two patches:
Refactor chanErr creation in async create
This patch changes the way the error channel is created during the async create workflow to make this more explicit and reduces the chances someone does not close the channel.
Refactor chanErr consumption in VM controller
This patch changes the way the error channel from the async create workflow is consumed in the VirtualMachine controller.
Previously only a single error was assumed to be returned, but since this is a channel, the consumer should range over it, accounting for the possible vim and k8s error.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: