🌱 Use errors.Is() to silence lint warnings #834
+22
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not opposed to this, but what IDE is giving these errors? VSCode does not, and our lint target does not. I wonder if we can do something in our linter to catch these. I agree we should use |
bryanv
force-pushed
the
bryanv/use-errors-is
branch
from
c549529 to
b64bd95
Compare
github-actions
bot
added
size/M
bryanv
changed the title
Add errorlint linter to golangci: only enable the wrapped error check until we fix all the others.
bryanv
force-pushed
the
bryanv/use-errors-is
branch
from
b64bd95 to
25ea363
Compare
Minimum allowed line rate is |
akutz
reviewed
Dec 19, 2024
| @@ -143,11 +143,16 @@ linters-settings: | |||
| desc: "replaced by internal packages like pkg/util/ptr" | |||
| - pkg: github.com/onsi/ginkgo$ | |||
| desc: "replaced by github.com/onsi/ginkgo/v2" | |||
|
|
|||
| errorlint: | |||
| # Check whether fmt.Errorf uses the %w verb for formatting errors. | |||
There was a problem hiding this comment.
I want Errorf to use %w to format errors. Why would we wish to disable that?
There was a problem hiding this comment.
That disables the lint for not using %w. There's lots of places where we're not and something that can be addressed later (along with the other disabled check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
In case these become wrapped errors later.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: