🌱 Allow imported and registered VMs to skip image validation checks on Create/Update #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreyasn
reviewed
Dec 6, 2024
akutz
reviewed
Dec 6, 2024
akutz
requested changes
Dec 6, 2024
aruneshpa
force-pushed
the
feature/relax-webhook-checks-for-import-and-registervm
branch
from
4d5df56 to
0d43914
Compare
akutz
requested changes
Dec 9, 2024
aruneshpa
force-pushed
the
feature/relax-webhook-checks-for-import-and-registervm
branch
from
0d43914 to
24e7329
Compare
github-actions
bot
added
size/XL
akutz
approved these changes
Dec 9, 2024
sreyasn
approved these changes
Dec 9, 2024
bryanv
reviewed
Dec 9, 2024
bryanv
approved these changes
Dec 9, 2024
…create/update VMs that are imported, or registered already have the virtual machine created on the infrastructure. As such, we don't need to apply the same strict validations for them such as making sure the image is not null / valid. To that end, this change introduces annotations that will be applied on the Imported, and Registered VMs. This will allow our webhooks to skip these checks if the annotation is present. For now, maintain the existing mechanism which allows _all_ VM creations to be imageless if the import or the incremental restore feature is enabled. Once this change is merged, we will yank out that code to make that check stricter (only annotation based).
aruneshpa
force-pushed
the
feature/relax-webhook-checks-for-import-and-registervm
branch
from
24e7329 to
d1b3d66
Compare
Minimum allowed line rate is |
aruneshpa
deleted the
feature/relax-webhook-checks-for-import-and-registervm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
VMs that are imported, or registered already have the virtual machine created on the infrastructure. As such, we don't need to apply the same strict validations for them such as making sure the image is not null / valid. To that end, this change introduces an annotation that will be applied on the Imported, or Registered VMs. This will allow our webhooks to skip these checks if the annotation is present.
For now, maintain the existing mechanism which allows all VM creations to be imageless if the import or the incremental restore feature is enabled. Once this change is merged, we will yank out that code to make that check stricter (only annotation based).
Are there any special notes for your reviewer:
There;s also a change to the UT method that validates messages. Instead of splitting that into a string array and matching elements, we are now comparing substrings. This is because the comma delimiter used to split the reasons results in false splits when a reason contains an object.
Please add a release note if necessary: