Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Ensure NICs are connected / start connected #805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akutz
Copy link
Collaborator

@akutz akutz commented Nov 21, 2024

What does this PR do, and why is it needed?

This patch adds support for VM Op ensuring NICs are always connected and start connected for VMs that are not paused either by an Admin or DevOps user.

Which issue(s) is/are addressed by this PR? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes NA

Are there any special notes for your reviewer:

@bryanv, please note that I ensured all the actual meat and potatoes logic is in the new resize location.

Please add a release note if necessary:

Ensure NICs are connected for VMs not paused by admin or DevOps users.

This patch adds support for VM Op ensuring NICs are always connected
and start connected for VMs that are not paused either by an Admin or
DevOps user.
@akutz akutz requested a review from bryanv November 21, 2024 16:10
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 21, 2024
@bryanv
Copy link
Contributor

bryanv commented Nov 21, 2024

This will change the behavior of when using GOSC in that the VM will boot with the NICs already connected, instead of that not happening until customization is complete. IDK if that's a necessarily a breaking change though.

@akutz
Copy link
Collaborator Author

akutz commented Nov 21, 2024

This will change the behavior of when using GOSC in that the VM will boot with the NICs already connected, instead of that not happening until customization is complete. IDK if that's a necessarily a breaking change though.

cc @PengpengSun

@PengpengSun
Copy link

This will change the behavior of when using GOSC in that the VM will boot with the NICs already connected, instead of that not happening until customization is complete. IDK if that's a necessarily a breaking change though.

cc @PengpengSun

Agree with Byran, please do not re-connect NICs before customization finishes in guest. When customizing network, connected NICs will create conflicts. If GOSC happens, GOSC will handle NICs re-connection.

@akutz
Copy link
Collaborator Author

akutz commented Nov 25, 2024

This will change the behavior of when using GOSC in that the VM will boot with the NICs already connected, instead of that not happening until customization is complete. IDK if that's a necessarily a breaking change though.

cc @PengpengSun

Agree with Byran, please do not re-connect NICs before customization finishes in guest. When customizing network, connected NICs will create conflicts. If GOSC happens, GOSC will handle NICs re-connection.

Hmmm. This is problematic. Ideally VM Operator should try to ensure the NICs are in the connected state. We should figure out how to do this even if GOSC is running or has run. Likely I'll do it by first checking the current status of a possible customization.

@PengpengSun
Copy link

This will change the behavior of when using GOSC in that the VM will boot with the NICs already connected, instead of that not happening until customization is complete. IDK if that's a necessarily a breaking change though.

cc @PengpengSun

Agree with Byran, please do not re-connect NICs before customization finishes in guest. When customizing network, connected NICs will create conflicts. If GOSC happens, GOSC will handle NICs re-connection.

Hmmm. This is problematic. Ideally VM Operator should try to ensure the NICs are in the connected state. We should figure out how to do this even if GOSC is running or has run. Likely I'll do it by first checking the current status of a possible customization.

GOSC won't re-connect NICs only if something wrong happened, at this point, even re-connect NICs by VM Operator, the status of the VM is unpredictable(network might/might not work).
And the connection status of the template/base vm needs to be considered too, if it's disconnected originally, GOSC will not re-connect NICs either.

If VM Operator wants to check customization status, this vAPI can be used. IMHO, no need re-connect NICs when customization fails, but VM Operator could have a different story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants