✨ Deprecate ProbeManager for non-TCP probes #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/guest-info-prober-uses-async-signal
branch
from
0c5e7fe to
6f5acbf
Compare
bryanv
reviewed
Nov 14, 2024
akutz
force-pushed
the
feature/guest-info-prober-uses-async-signal
branch
from
6f5acbf to
7e7b67e
Compare
This patch deprecates the use of ProbeManager for non-TCP probes when the AsyncSignal feature is enabled. This is because VMs will be reconciled as soon as their heartbeat or guestinfo information is updated, and thus readiness can be determined in the normal VM reconcile loop.
akutz
force-pushed
the
feature/guest-info-prober-uses-async-signal
branch
from
7e7b67e to
78e2510
Compare
bryanv
approved these changes
Nov 14, 2024
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch deprecates the use of ProbeManager for non-TCP probes when the AsyncSignal feature is enabled. This is because VMs will be reconciled as soon as their heartbeat or guestinfo information is updated, and thus readiness can be determined in the normal VM reconcile loop.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: