-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update NSX Operator API for VPC DHCP CRD change #799
Merged
zyiyi11
merged 1 commit into
vmware-tanzu:main
from
zyiyi11:topic/zyiyi/vpc-api-dhcp-change
Nov 19, 2024
Merged
🌱 Update NSX Operator API for VPC DHCP CRD change #799
zyiyi11
merged 1 commit into
vmware-tanzu:main
from
zyiyi11:topic/zyiyi/vpc-api-dhcp-change
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
dilyar85
approved these changes
Nov 13, 2024
bryanv
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
With the changes on https://github.com/vmware-tanzu/nsx-operator/commits/v4.2.0/, now creating DHCP subnet/subnetSet is using below spec. VM Operator consumes this API, nothing else needs to be updated.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # N/A
Are there any special notes for your reviewer:
Please add a release note if necessary: