✨ Rekey disks for encrypted VMs #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/byok-rekey-disks
branch
from
e454d7b to
4032323
Compare
akutz
changed the title
dougm
approved these changes
Oct 24, 2024
akutz
force-pushed
the
feature/byok-rekey-disks
branch
from
4032323 to
f52b1ee
Compare
github-actions
bot
added
size/XL
akutz
force-pushed
the
feature/byok-rekey-disks
branch
2 times, most recently
from
fe208c5 to
d059840
Compare
This patch supports rekeying disks when an encrypted VM is rekeyed.
akutz
force-pushed
the
feature/byok-rekey-disks
branch
from
d059840 to
15b0cf0
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch supports rekeying disks when an encrypted VM is rekeyed.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please note,
IsEncryptedStorageClassreturns the profile ID, even though it is not used right now. It was used in rekeying the disks, but it turns out it is not required for shallow recrypt. Still, it seems very useful to have the function return the underlying profile ID as well to save an extra call, thus it has remained as a return value.Please add a release note if necessary:
📚 Documentation preview 📚: https://vm-operator--765.org.readthedocs.build/en/765/