-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Skip resizing ISO VM boot disk #732
Merged
dilyar85
merged 1 commit into
vmware-tanzu:main
from
dilyar85:bugfix/skip-resize-iso-disk
Oct 9, 2024
Merged
🐛 Skip resizing ISO VM boot disk #732
dilyar85
merged 1 commit into
vmware-tanzu:main
from
dilyar85:bugfix/skip-resize-iso-disk
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreyasn
approved these changes
Oct 4, 2024
dilyar85
force-pushed
the
bugfix/skip-resize-iso-disk
branch
from
October 7, 2024 13:55
b990f26
to
d94e955
Compare
Minimum allowed line rate is |
zyiyi11
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This PR updates the
bootDiskCapacity
reconciliation process to skip resizing boot disks for ISO VMs since they're managed by PVCs. It also updates the API docs to reflect this behavior.Which issue(s) is/are addressed by this PR?
Fixes N/A.
Are there any special notes for your reviewer:
We're not enforcing this via webhook to minimize changes to the current ISO workflow. A future release may introduce this enforcement or add support for resizing ISO VM boot disks.
Please add a release note if necessary:
📚 Documentation preview 📚: https://vm-operator--732.org.readthedocs.build/en/732/