Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Deploy VM w additional disk from PVC #537

Merged
merged 1 commit into from
May 28, 2024
Merged

📖 Deploy VM w additional disk from PVC #537

merged 1 commit into from
May 28, 2024

Conversation

akutz
Copy link
Collaborator

@akutz akutz commented May 28, 2024 •
edited by github-actions bot
Loading

What does this PR do, and why is it needed?

This patch provides a documentation example for how to deploy a VM with an additional disk provided by a PVC.

Which issue(s) is/are addressed by this PR? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes NA

Are there any special notes for your reviewer:

Please add a release note if necessary:

Tutorial on deploying VM with additional disk provided by PVC

📚 Documentation preview 📚: https://vm-operator--537.org.readthedocs.build/en/537/

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label May 28, 2024
@akutz akutz force-pushed the docs/attach-and-mount-pvc-example branch 3 times, most recently from 475ef79 to c875123 Compare May 28, 2024 14:54
mayankbh
mayankbh approved these changes May 28, 2024
View reviewed changes
docs/tutorials/deploy-vm/with-pvc.md Outdated Show resolved Hide resolved
docs/tutorials/deploy-vm/with-pvc.md Outdated Show resolved Hide resolved
docs/tutorials/deploy-vm/with-pvc.md Show resolved Hide resolved
@akutz akutz force-pushed the docs/attach-and-mount-pvc-example branch 4 times, most recently from d8a5189 to 96bfba9 Compare May 28, 2024 15:16
@akutz
docs: Deploy VM w additional disk from PVC
80fedd7 
This patch provides a documentation example for how to deploy a VM
with an additional disk provided by a PVC.
@akutz akutz force-pushed the docs/attach-and-mount-pvc-example branch from 96bfba9 to 80fedd7 Compare May 28, 2024 15:18
@akutz akutz merged commit 411440e into vmware-tanzu:main May 28, 2024
12 checks passed
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
github.com/vmware-tanzu/vm-operator/api/v1alpha1 42% ❌
github.com/vmware-tanzu/vm-operator/api/v1alpha2 9% ❌
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem 82% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem 86% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils 32% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/configmap 71% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/node 77% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/secret 77% ➖
github.com/vmware-tanzu/vm-operator/controllers/util/encoding 73% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine 77% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass 21% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest 81% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice 83% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers 92% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy 81% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 72% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions 88% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch 78% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha2 73% ➖
github.com/vmware-tanzu/vm-operator/controllers/volume 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/builder 15% ❌
github.com/vmware-tanzu/vm-operator/pkg/conditions 88% ✔
github.com/vmware-tanzu/vm-operator/pkg/config 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/env 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/patch 16% ❌
github.com/vmware-tanzu/vm-operator/pkg/prober 54% ❌
github.com/vmware-tanzu/vm-operator/pkg/prober/probe 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker 77% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere 72% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/client 80% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules 71% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config 72% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary 72% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement 77% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session 33% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/sysprep 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter 82% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine 74% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle 66% ➖
github.com/vmware-tanzu/vm-operator/pkg/record 78% ➖
github.com/vmware-tanzu/vm-operator/pkg/topology 55% ❌
github.com/vmware-tanzu/vm-operator/pkg/util 78% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/image 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube 81% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/resize 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1 93% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client 68% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm 78% ➖
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation 51% ❌
github.com/vmware-tanzu/vm-operator/webhooks/common 100% ✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation 86% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation 62% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinereplicaset/validation 90% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation 67% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha2/validation 92% ✔
Summary 56% (8330 / 14793) ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayankbh mayankbh mayankbh approved these changes

Assignees
No one assigned
Labels
cla-not-required size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akutz @mayankbh @vmwclabot