🐛 Fix generated CloudConfig type via Docker #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a weird issue when generate the Golang type(s) for a Cloud-Init CloudConfig. When generating them via Docker, the program quicktype used the schema's filename as part of the generated types. This caused the file to look different when generated locally versus when generated via a container.
akutz
force-pushed
the
fix/cloud-config-schema-type-names
branch
from
e4eb20b to
6246ebf
Compare
bryanv
approved these changes
Dec 18, 2023
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch fixes a weird issue when generate the Golang type(s) for a Cloud-Init CloudConfig. When generating them via Docker, the program quicktype used the schema's filename as part of the generated types. This caused the file to look different when generated locally versus when generated via a container.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: