✨ Add VirtualMachine conversion tests #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing-needed-e2e-fast
size/L
bryanv
force-pushed
the
bryanv/more-vm-conversion-tests
branch
4 times, most recently
from
25a7feb to
f8b30d4
Compare
sreyasn
approved these changes
Dec 13, 2023
bryanv
force-pushed
the
bryanv/more-vm-conversion-tests
branch
from
f8b30d4 to
efc49c8
Compare
Why do we want to eval the status? Should we not configure a filter that ignores updates to the status sub-resource? |
bryanv
force-pushed
the
bryanv/more-vm-conversion-tests
branch
from
efc49c8 to
c5bf8e0
Compare
If the Spec changes, then yes. I don't think we're using the filter to skip the Status updated induced reconcile ATM. |
bryanv
force-pushed
the
bryanv/more-vm-conversion-tests
branch
from
c5bf8e0 to
615996c
Compare
Sorry, I mean we never "evaluate" the status, or rather, we shouldn't. We construct it by evaluating and reconciling the spec. I think we just thought different things when we used the word "reevaluate." |
bryanv
force-pushed
the
bryanv/more-vm-conversion-tests
branch
3 times, most recently
from
e7bedff to
f793c5e
Compare
Start with a nearly fully populated v1a2 VM and ensure that the VM resulting from conversion is the same. We can keep adding these explicit conversion tests to ensure that fields are converted as we expect instead of always depending on the fuzzer. Add typical v1a1 TKG VM and ensure spoke-hub-spoke conversion works. Fix a few conversion issues around the Network and Advanced fields. Always restore the full VM Status from the annotations. Our controller should be the only one updating the Status, and an update from the conversion will cause our controllers to reconcile and reevaluate the Status.
bryanv
force-pushed
the
bryanv/more-vm-conversion-tests
branch
from
f793c5e to
8b0ed54
Compare
github-actions
bot
added
size/XL
Minimum allowed line rate is |
bryanv
added
the
testing-done-e2e-fast
bryanv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start with a nearly fully populated v1a2 VM and ensure that the VM resulting from conversion is the same. We can keep adding these explicit conversion tests to ensure that fields are converted as we expect instead of always depending on the fuzzer.
Fix a few conversion issues around the Network and Advanced fields.
Always restore the full VM status from the annotations. Our controller should be the only one updating the Status, and an update from the conversion will cause our controllers to reconcile and reevaluate the Status.