🐛 Remove updates to DeviceGroups #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the update of deviceGroups in the UpdateVM path. We don't currently support this workflow on Update and DeviceGroups are already covered in the CreatePath. This code for this currently incomplete to support deviceGroups on update and will be prioritized when we support Resizing VMs in VM operator.
github-actions
bot
added
testing-needed-e2e-fast
size/L
bryanv
approved these changes
Nov 9, 2023
sreyasn
added
the
testing-done-e2e-fast
Minimum allowed line rate is |
sreyasn
added a commit
to sreyasn/vm-operator
that referenced
this pull request
Jan 16, 2024
This change removes the update of deviceGroups in the UpdateVM path. We don't currently support this workflow on Update and DeviceGroups are already covered in the CreatePath. The code for this currently incomplete to support deviceGroups on update and will be prioritized when VM Operator supports resizing VMs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This change removes the update of deviceGroups in the UpdateVM path. We don't currently support this workflow on Update and DeviceGroups are already covered in the CreatePath. The code for this is currently incomplete to support deviceGroups on update and will be prioritized when we support Resizing VMs in VM operator.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # N/A
Are there any special notes for your reviewer:
N/A
Please add a release note if necessary: