✨ v1a2 provider & api changes #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing-needed-e2e-fast
size/XXL
bryanv
force-pushed
the
bryanv/v1a2-mr
branch
from
6ab7bfa to
862586c
Compare
sreyasn
reviewed
Sep 22, 2023
sreyasn
reviewed
Sep 22, 2023
sreyasn
reviewed
Sep 22, 2023
sreyasn
reviewed
Sep 22, 2023
sreyasn
reviewed
Sep 25, 2023
|
Also JFYI @bryanv , Keep an eye out on the BackupVirtualMachine() method added to the v1a2 interface. Without the provider for this the cayman_vm-operator build will fail. |
bryanv
force-pushed
the
bryanv/v1a2-mr
branch
from
1a24c7d to
29f7b0e
Compare
aruneshpa
approved these changes
Sep 27, 2023
bryanv
force-pushed
the
bryanv/v1a2-mr
branch
2 times, most recently
from
65699bf to
b657974
Compare
sreyasn
approved these changes
Sep 28, 2023
bryanv
force-pushed
the
bryanv/v1a2-mr
branch
4 times, most recently
from
313db14 to
2534f3d
Compare
bryanv
added
testing-done-e2e-fast
bryanv
force-pushed
the
bryanv/v1a2-mr
branch
from
2534f3d to
b548d7b
Compare
There is still a lot of work left to do before switching over to v1a2 but this is able to create TKGs with everything else still only understanding v1a1, so we have a good baseline of version conversion and functionality. Unfortunately the way the existing code is and our need to support the existing v1a1 and new v1a2 APIs in the same codebase makes this a large and painful change. The goal is to wrap up the remaining items as quickly as possible so we can move to v1a2 and then really start to focus on some of our long term tech debt so future version bumps aren't nearly as painful.
We'll likely need the existing v1a1 mutation webhooks for some types - definitely for the VM - but that can wait to be addressed later. However, we will not need both v1a1 and v1a2 validation webhooks since the v1a2 hooks will cover v1a1 after version conversion. Correct some package names from 9869e81
This is used for the version conversion wehbooks. This can also support validation and mutation webhooks but our own webhook framework predates ctrl-runtime support for that so that is an improvement for later.
bryanv
force-pushed
the
bryanv/v1a2-mr
branch
from
b548d7b to
865f407
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot of the current v1a2 work. This overall effort still has a lot of things to sort out but this works well enough to create working TKGs, with everything else will using v1a1 so we have a baseline of version conversion and functionality.