✨ Add v1a2 webconsole request controllers #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing-needed-e2e-fast
size/XL
bryanv
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
It is a relative drop in the bucket for the rest of the tech debt we're saddling ourselves with for v1a2 but since the v1a1 controller/webhooks have to be kept around until v1a1 is completely removed, there is an opportunity now or later to share code here, either by writing our own ConverTo/From() or by defining our own generic intermediary struct.
controllers/virtualmachinewebconsolerequest/v1alpha2/webconsolerequest_controller.go
Outdated
Show resolved
Hide resolved
Minimum allowed line rate is |
sreyasn
added
the
testing-done-e2e-fast
aruneshpa
pushed a commit
to aruneshpa/vm-operator
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This change adds the v1a2 virtualmachinewebconsolerequest controllers and tests. The controller is guarded by the Feature state switch. The webhook changes will be a follow-up of this PR.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # N/A
Are there any special notes for your reviewer:
N/A
Please add a release note if necessary: