-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix bug when using CloudInit without userdata to bootstrap VM #211
Merged
zyiyi11
merged 2 commits into
vmware-tanzu:main
from
zyiyi11:zyiyi/cloudinit-sans-userdata
Sep 14, 2023
Merged
🐛 fix bug when using CloudInit without userdata to bootstrap VM #211
zyiyi11
merged 2 commits into
vmware-tanzu:main
from
zyiyi11:zyiyi/cloudinit-sans-userdata
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing-needed-e2e-fast
size/L
Denotes a PR that changes 100-499 lines.
labels
Aug 30, 2023
zyiyi11
added
the
testing-done-e2e-full
Indicates the complete e2e testing has been used to validate a PR
label
Aug 30, 2023
zyiyi11
force-pushed
the
zyiyi/cloudinit-sans-userdata
branch
from
August 30, 2023 20:26
bf143fb
to
c182c2c
Compare
zyiyi11
added
the
testing-done-e2e-fast
Indicates the fast, low-cost e2e testing has been used to validate a PR
label
Aug 30, 2023
zyiyi11
force-pushed
the
zyiyi/cloudinit-sans-userdata
branch
from
August 30, 2023 23:14
c182c2c
to
d6a76ed
Compare
zyiyi11
force-pushed
the
zyiyi/cloudinit-sans-userdata
branch
3 times, most recently
from
September 11, 2023 22:03
475ef29
to
fb0fa62
Compare
dilyar85
reviewed
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments mostly for suggestions. Overall looks good to me.
pkg/vmprovider/providers/vsphere/session/session_vm_customization.go
Outdated
Show resolved
Hide resolved
pkg/vmprovider/providers/vsphere/session/session_vm_customization.go
Outdated
Show resolved
Hide resolved
webhooks/virtualmachine/v1alpha1/validation/virtualmachine_validator.go
Outdated
Show resolved
Hide resolved
webhooks/virtualmachine/v1alpha1/validation/virtualmachine_validator.go
Outdated
Show resolved
Hide resolved
zyiyi11
force-pushed
the
zyiyi/cloudinit-sans-userdata
branch
2 times, most recently
from
September 12, 2023 16:29
a35e8c5
to
e62c64b
Compare
dilyar85
approved these changes
Sep 14, 2023
webhooks/virtualmachine/v1alpha1/validation/virtualmachine_validator.go
Outdated
Show resolved
Hide resolved
zyiyi11
force-pushed
the
zyiyi/cloudinit-sans-userdata
branch
from
September 14, 2023 16:53
e62c64b
to
4c2198d
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-not-required
size/L
Denotes a PR that changes 100-499 lines.
testing-done-e2e-fast
Indicates the fast, low-cost e2e testing has been used to validate a PR
testing-done-e2e-full
Indicates the complete e2e testing has been used to validate a PR
testing-needed-e2e-fast
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This change fixes the bug when using CloudInit transport to bootstrap a VM, not passing user data actually results VM customized with GOSC (LinuxPrep). This patch introduced an annotation to set Cloudinit metadata instance-id and also introduced a webhook to prevent SSO users from setting the annotation manually.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes 221
Are there any special notes for your reviewer:
Testing done:
guestinfo.metadata
got set successfully.brownfield scenario change in cayman_vm-operator:
upgrade logic to:
Please add a release note if necessary: