v1alpha3

This patch introduces schema version v1alpha3. This patch
only includes plumbing changes for the API definitions, which,
at this time, are a one-for-one copy of v1alpha2. This change
allows developers to make updates to the API on main without
impacting v1alpha2, which is locked.

.golangci.yml

@@ -19,6 +19,10 @@ linters-settings:
       - pkg: k8s.io/api/core/v1
         alias: corev1
       - pkg: github.com/vmware-tanzu/vm-operator/api/v1alpha1
+        alias: vmopv1a1
+      - pkg: github.com/vmware-tanzu/vm-operator/api/v1alpha2
+        alias: vmopv1a2
+      - pkg: github.com/vmware-tanzu/vm-operator/api/v1alpha3
         alias: vmopv1
       - pkg: "github.com/vmware-tanzu/vm-operator/pkg/config"
         alias: pkgconfig

Makefile

@@ -328,7 +328,7 @@ endif
 
 generate-go-conversions:
 	$(CONVERSION_GEN) \
-		--input-dirs=./api/v1alpha1 \
+		--input-dirs='./api/v1alpha1,./api/v1alpha2' \
 		--output-file-base=zz_generated.conversion \
 		--go-header-file=./hack/boilerplate/boilerplate.generatego.txt
 

api/v1alpha1/conversion_test.go

@@ -17,7 +17,7 @@ import (
 	"github.com/vmware-tanzu/vm-operator/pkg/constants/testlabels"
 
 	"github.com/vmware-tanzu/vm-operator/api/v1alpha1"
-	nextver "github.com/vmware-tanzu/vm-operator/api/v1alpha2"
+	nextver "github.com/vmware-tanzu/vm-operator/api/v1alpha3"
 )
 
 var _ = Describe("FuzzyConversion", Label(testlabels.API, testlabels.Fuzz), func() {
@@ -310,6 +310,14 @@ func overrideVirtualMachineImageFieldsFuncs(codecs runtimeserializer.CodecFactor
 			// TODO: Need to save serialized object to support lossless conversions.
 			imageStatus.Capabilities = nil
 		},
+		func(imageSpec *nextver.VirtualMachineImageSpec, c fuzz.Continue) {
+			c.Fuzz(imageSpec)
+			if pr := imageSpec.ProviderRef; pr != nil {
+				if pr.APIVersion == "" && pr.Kind == "" && pr.Name == "" {
+					imageSpec.ProviderRef = nil
+				}
+			}
+		},
 	}
 }
 

api/v1alpha1/doc.go

@@ -1,10 +1,10 @@
-// Copyright (c) 2020 VMware, Inc. All Rights Reserved.
+// Copyright (c) 2020-2024 VMware, Inc. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
 // Package v1alpha1 contains the VM Operator v1alpha1 APIs.
 //
 // +k8s:openapi-gen=true
 // +kubebuilder:object:generate=true
 // +groupName=vmoperator.vmware.com
-// +k8s:conversion-gen=github.com/vmware-tanzu/vm-operator/api/v1alpha2
+// +k8s:conversion-gen=github.com/vmware-tanzu/vm-operator/api/v1alpha3
 package v1alpha1