Use errors.Is()

Add errorlint linter to golangci: only enable the wrapped
error check until we fix all the others.

.golangci.yml

@@ -143,11 +143,16 @@ linters-settings:
           desc: "replaced by internal packages like pkg/util/ptr"
         - pkg: github.com/onsi/ginkgo$
           desc: "replaced by github.com/onsi/ginkgo/v2"
-
+  errorlint:
+    # Check whether fmt.Errorf uses the %w verb for formatting errors.
+    errorf: false
+    # Check for plain type assertions and type switches.
+    asserts: false
 
 linters:
   disable-all: true
   enable:
+  - errorlint
   - asciicheck
   - bodyclose
   - depguard

cmd/web-console-validator/main.go

@@ -4,6 +4,7 @@
 package main
 
 import (
+	"errors"
 	"flag"
 	"net/http"
 	"os"
@@ -93,7 +94,7 @@ func main() {
 	}
 
 	logger.Info("Starting the web-console validation server", "port", *serverPort, "path", *serverPath)
-	if err := server.Run(); err != nil && err != http.ErrServerClosed {
+	if err := server.Run(); err != nil && !errors.Is(err, http.ErrServerClosed) {
 		logger.Error(err, "Failed to run the web-console validation server")
 		os.Exit(1)
 	}

controllers/infra/zone/zone_controller.go

@@ -5,6 +5,7 @@ package zone
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"reflect"
 	"strings"
@@ -131,7 +132,7 @@ func (r *Reconciler) ReconcileDelete(
 				},
 				fmt.Sprintf("%s/%s", obj.Namespace, obj.Name)); err != nil {
 
-				if err != watcher.ErrAsyncSignalDisabled {
+				if !errors.Is(err, watcher.ErrAsyncSignalDisabled) {
 					return ctrl.Result{}, err
 				}
 			}
@@ -157,7 +158,7 @@ func (r *Reconciler) ReconcileNormal(
 				},
 				fmt.Sprintf("%s/%s", obj.Namespace, obj.Name)); err != nil {
 
-				if err != watcher.ErrAsyncSignalDisabled {
+				if !errors.Is(err, watcher.ErrAsyncSignalDisabled) {
 					return ctrl.Result{}, err
 				}
 			}

controllers/util/encoding/encoding.go

@@ -6,6 +6,7 @@ package encoding
 import (
 	"bufio"
 	"bytes"
+	"errors"
 	"fmt"
 	"io"
 
@@ -33,7 +34,7 @@ func DecodeYAML(data []byte) (<-chan *unstructured.Unstructured, <-chan error) {
 		for {
 			buf, err := multidocReader.Read()
 			if err != nil {
-				if err == io.EOF {
+				if errors.Is(err, io.EOF) {
 					return
 				}
 				chanErr <- fmt.Errorf("failed to read yaml data: %w", err)

controllers/virtualmachine/virtualmachine/virtualmachine_controller.go

@@ -555,10 +555,10 @@ func getIsDefaultVMClassController(ctx context.Context) bool {
 // ignoredCreateErr is written this way in order to illustrate coverage more
 // accurately.
 func ignoredCreateErr(err error) bool {
-	if err == providers.ErrDuplicateCreate {
+	if errors.Is(err, providers.ErrDuplicateCreate) {
 		return true
 	}
-	if err == providers.ErrTooManyCreates {
+	if errors.Is(err, providers.ErrTooManyCreates) {
 		return true
 	}
 	return false

pkg/util/vsphere/vm/power_state.go

@@ -382,7 +382,7 @@ func doAndWaitOnSoftPowerOp(
 	defer cancel()
 
 	if err := waitForPowerStateFn(ctx, desiredPowerState); err != nil {
-		if ctx.Err() == context.DeadlineExceeded {
+		if errors.Is(ctx.Err(), context.DeadlineExceeded) {
 			return 0, fmt.Errorf("timed out waiting for power state %s", desiredPowerState)
 		}
 		return 0, fmt.Errorf("failed to wait for power state %s %w", desiredPowerState, err)
@@ -606,7 +606,7 @@ func doAndWaitOnSoftRestart(
 	defer cancel()
 
 	if err := powerOpFn(ctx); err != nil {
-		if ctx.Err() == context.DeadlineExceeded {
+		if errors.Is(ctx.Err(), context.DeadlineExceeded) {
 			return 0, errors.New("timed out while soft restarting vm")
 		}
 		return 0, fmt.Errorf("failed to soft restart vm %w", err)

pkg/vmconfig/crypto/crypto_reconciler_pre.go

@@ -383,7 +383,7 @@ func (r reconciler) reconcileUpdateDefaultKeyProvider(
 }
 
 func setConditionAndReturnErr(args reconcileArgs, err error, r Reason) error {
-	if err == ErrInvalidKeyProvider || err == ErrInvalidKeyID {
+	if errors.Is(err, ErrInvalidKeyProvider) || errors.Is(err, ErrInvalidKeyID) {
 		r = ReasonEncryptionClassInvalid
 	} else if apierrors.IsNotFound(err) {
 		r = ReasonEncryptionClassNotFound

test/builder/util.go

@@ -7,6 +7,7 @@ import (
 	"bufio"
 	"bytes"
 	"context"
+	"errors"
 	"io"
 	"os"
 	"path/filepath"
@@ -111,7 +112,7 @@ func readDocuments(fp string) ([][]byte, error) {
 		// Read document
 		doc, err := reader.Read()
 		if err != nil {
-			if err == io.EOF {
+			if errors.Is(err, io.EOF) {
 				break
 			}
 			return nil, err

webhooks/virtualmachine/mutation/virtualmachine_mutator.go

@@ -6,6 +6,7 @@ package mutation
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"net/http"
 	"reflect"
@@ -596,7 +597,7 @@ func SetDefaultEncryptionClass(
 		k8sClient,
 		vm.Namespace)
 	if err != nil {
-		if err == kubeutil.ErrNoDefaultEncryptionClass {
+		if errors.Is(err, kubeutil.ErrNoDefaultEncryptionClass) {
 			return false, nil
 		}
 		return false, err