Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8044: generic restore - allow to ignore delay binding for WaitForFirstConsumer #8550

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Dec 24, 2024

Fix issue #8044, allow users to ignore delay binding the restorePVC of data mover when it is in WaitForFirstConsumer mode

@Lyndon-Li Lyndon-Li force-pushed the restore-pvc-ignore-wait-for-first-consumer branch from 505f06b to 5b1f3bd Compare December 24, 2024 02:28
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.16%. Comparing base (6860dab) to head (cfad06b).

Files with missing lines Patch % Lines
pkg/cmd/cli/nodeagent/server.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8550      +/-   ##
==========================================
- Coverage   59.18%   59.16%   -0.02%     
==========================================
  Files         370      370              
  Lines       39591    39605      +14     
==========================================
+ Hits        23433    23434       +1     
- Misses      14677    14689      +12     
- Partials     1481     1482       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the restore-pvc-ignore-wait-for-first-consumer branch from 5b1f3bd to 423065a Compare December 26, 2024 02:28
@Lyndon-Li Lyndon-Li force-pushed the restore-pvc-ignore-wait-for-first-consumer branch from 423065a to a56b06b Compare December 26, 2024 02:29
@Lyndon-Li Lyndon-Li changed the title Issue 8044: generic restore - allow to ignore WaitForFirstConsumer Issue 8044: generic restore - allow to ignore delay binding for WaitForFirstConsumer Dec 26, 2024
@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 26, 2024 02:30
@Lyndon-Li Lyndon-Li requested a review from ywk253100 January 3, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants