Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Modify the StorageClass install and delete code. #8530

Merged

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Dec 19, 2024

  • Only install and uninstall SC and VSC once for default cluster.
  • Install and uninstall SC and VSC for standby cluster on migration case.
  • Refactor the StorageClass and VolumeSnapshotClass YAMLs.
  • Prettify the e2e_suite_test.go

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

* Only install and uninstall SC and VSC once for default cluster.
* Install and uninstall SC and VSC for standby cluster on migration case.
* Refactor the StorageClass and VolumeSnapshotClass YAMLs.
* Prettify the e2e_suite_test.go

Signed-off-by: Xun Jiang <[email protected]>
@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.11%. Comparing base (a01e82d) to head (e78d082).
Report is 3 commits behind head on release-1.15.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.15    #8530   +/-   ##
=============================================
  Coverage         59.11%   59.11%           
=============================================
  Files               367      367           
  Lines             39118    39118           
=============================================
  Hits              23126    23126           
  Misses            14523    14523           
  Partials           1469     1469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet marked this pull request as ready for review December 19, 2024 07:00
@reasonerjt reasonerjt merged commit 49a8e24 into vmware-tanzu:release-1.15 Dec 19, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants