-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVE-2024-45337 #8514
CVE-2024-45337 #8514
Conversation
/kind changelog-not-required |
Please signoff all your commits https://github.com/vmware-tanzu/velero/pull/8514/checks?check_run_id=34572716368
and force push. |
Please also help to bump the version of Please check #8526 for reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use vendor in this repo. Please remove vendor folder.
We could remove for you but this PR is from your main branch, please let us know if you'd like us to commit to your main branch for you.
And reminder to signoff ALL your commits in the PR. https://github.com/vmware-tanzu/velero/pull/8514/checks?check_run_id=34673896265
|
The change will fix CVE-2023-45288 Vulnerability details: https://nvd.nist.gov/vuln/detail/CVE-2024-45337 Fix: golang/go#70779 Signed-off-by: Kamlesh Verma <[email protected]> Signed-off-by: kamlesh VERMA <[email protected]>
Signed-off-by: kamlesh VERMA <[email protected]>
Fix backup post hook issue Fixes vmware-tanzu#8159 Signed-off-by: Wenkai Yin(尹文开) <[email protected]> Signed-off-by: kamlesh VERMA <[email protected]>
The issue is caused by the changes of controller-runtime: WithEventFilter() doesn't apply to WatchesRawSource(), this commit set Predicate for WatchesRawSource() seperatedly Fixes vmware-tanzu#8437 Signed-off-by: Wenkai Yin(尹文开) <[email protected]> Signed-off-by: kamlesh VERMA <[email protected]>
Signed-off-by: Lyndon-Li <[email protected]> Signed-off-by: kamlesh VERMA <[email protected]>
Signed-off-by: kamlesh VERMA <[email protected]>
Signed-off-by: kamlesh VERMA <[email protected]> Signed-off-by: kamlesh VERMA <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is containing a bunch of unrelated changes now.
ie. the number of files changed is not just go.mod go.sum.
I'll open another PR if that is ok with you. Or please let me know if you prefer us to modify this branch.
Replaces vmware-tanzu#8514 Signed-off-by: Tiger Kaovilai <[email protected]>
Opened #8541 which covers the CVEs discussed in this PR. |
Sure no problem. Let me close this PR. |
The change will fix CVE-2023-45288
Vulnerability details: https://nvd.nist.gov/vuln/detail/CVE-2024-45337
Fix: golang/go#70779
Thank you for contributing to Velero!
Please add a summary of your change
As per NVD, Applications and libraries which misuse the ServerConfig.PublicKeyCallback callback may be susceptible to an authorization bypass.Specifically, the SSH protocol allows clients to inquire about whether a public key is acceptable before proving control of the corresponding private key.
Does your change fix a particular issue?
Yes. It will fix CVE-2023-45288 vulnerability.
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.