Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2024-45337 #8514

Closed
wants to merge 7 commits into from
Closed

CVE-2024-45337 #8514

wants to merge 7 commits into from

Conversation

vkamlesh
Copy link

The change will fix CVE-2023-45288

Vulnerability details: https://nvd.nist.gov/vuln/detail/CVE-2024-45337
Fix: golang/go#70779

Thank you for contributing to Velero!

Please add a summary of your change

As per NVD, Applications and libraries which misuse the ServerConfig.PublicKeyCallback callback may be susceptible to an authorization bypass.Specifically, the SSH protocol allows clients to inquire about whether a public key is acceptable before proving control of the corresponding private key.

Does your change fix a particular issue?

Yes. It will fix CVE-2023-45288 vulnerability.

Fixes #(issue)

Please indicate you've done the following:

@vkamlesh
Copy link
Author

/kind changelog-not-required

@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Dec 16, 2024
@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Dec 16, 2024
@blackpiglet
Copy link
Contributor

@vkamlesh
Please run go mod tidy to update the related package versions in the go.mod and go.sum files.
Please take this PR #8519 as an example.

@kaovilai
Copy link
Member

Please signoff all your commits https://github.com/vmware-tanzu/velero/pull/8514/checks?check_run_id=34572716368

git rebase HEAD~2 --signoff

and force push.

go.mod Outdated Show resolved Hide resolved
@blackpiglet
Copy link
Contributor

Please also help to bump the version of golang.org/x/net to v0.33.0 to fix GHSA-w32m-9786-jp63.

Please check #8526 for reference.

Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use vendor in this repo. Please remove vendor folder.

We could remove for you but this PR is from your main branch, please let us know if you'd like us to commit to your main branch for you.

@kaovilai
Copy link
Member

And reminder to signoff ALL your commits in the PR.

https://github.com/vmware-tanzu/velero/pull/8514/checks?check_run_id=34673896265

Commit sha: [829d626](https://github.com/vmware-tanzu/velero/pull/8514/commits/829d626390bda91cf081672c4a03ab5d6aa3e0b8), Author: kamlesh VERMA, Committer: kamlesh VERMA; The sign-off is missing.
Commit sha: [0f0a3dd](https://github.com/vmware-tanzu/velero/pull/8514/commits/0f0a3dde3741eb8f8be51506bb881eafd410e387), Author: kamlesh VERMA, Committer: kamlesh VERMA; The sign-off is missing.

vkamlesh and others added 7 commits December 20, 2024 23:00
The change will fix CVE-2023-45288

Vulnerability details:  https://nvd.nist.gov/vuln/detail/CVE-2024-45337
Fix: golang/go#70779

Signed-off-by: Kamlesh Verma <[email protected]>
Signed-off-by: kamlesh VERMA <[email protected]>
Fix backup post hook issue

Fixes vmware-tanzu#8159

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Signed-off-by: kamlesh VERMA <[email protected]>
The issue is caused by the changes of controller-runtime: WithEventFilter() doesn't apply to WatchesRawSource(),
this commit set Predicate for WatchesRawSource() seperatedly

Fixes vmware-tanzu#8437

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Signed-off-by: kamlesh VERMA <[email protected]>
Signed-off-by: Lyndon-Li <[email protected]>
Signed-off-by: kamlesh VERMA <[email protected]>
Signed-off-by: kamlesh VERMA <[email protected]>

Signed-off-by: kamlesh VERMA <[email protected]>
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is containing a bunch of unrelated changes now.
ie. the number of files changed is not just go.mod go.sum.

I'll open another PR if that is ok with you. Or please let me know if you prefer us to modify this branch.

kaovilai added a commit to kaovilai/velero that referenced this pull request Dec 20, 2024
Replaces vmware-tanzu#8514

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai mentioned this pull request Dec 20, 2024
3 tasks
@kaovilai
Copy link
Member

Opened #8541 which covers the CVEs discussed in this PR.

@vkamlesh
Copy link
Author

This PR is containing a bunch of unrelated changes now. ie. the number of files changed is not just go.mod go.sum.

I'll open another PR if that is ok with you. Or please let me know if you prefer us to modify this branch.

Sure no problem. Let me close this PR.

@vkamlesh vkamlesh closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/crypto/ssh: misuse of ServerConfig.PublicKeyCallback may cause authorization bypass
5 participants