Bump GitHub action versions. #213
Open
+11
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
bump_action_versions
branch
from
155c979 to
16da899
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 28.59% 28.59%
=======================================
Files 4 4
Lines 570 570
=======================================
Hits 163 163
Misses 395 395
Partials 12 12 ☔ View full report in Codecov by Sentry. |
kaovilai
approved these changes
Dec 19, 2024
reasonerjt
reviewed
Dec 20, 2024
|
|
||
| uploader ${VELERO_PLUGIN_IMAGE_FILE} ${GCS_BUCKET} | ||
| uploader ${VELERO_PLUGIN_IMAGE_BACKUP_FILE} ${GCS_BUCKET} | ||
| ./hack/docker-push.sh |
There was a problem hiding this comment.
How does docker-push.sh push to GCR? I see the last line in the script is calling "make container"
There was a problem hiding this comment.
velero-plugin-for-gcp/hack/docker-push.sh
Line 99 in 04062a6
that is how. When you build with this output type, the result is a pushed image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.