-
Notifications
You must be signed in to change notification settings - Fork 192
Add logic to put cluster labels and package labels on resources for custom cluster bootstrap scenario #4544
base: main
Are you sure you want to change the base?
Conversation
CVE Scan results for this PR can be viewed from |
You have successfully added a new Trivy configuration |
Codecov Report
@@ Coverage Diff @@
## main #4544 +/- ##
==========================================
- Coverage 49.77% 48.91% -0.87%
==========================================
Files 453 483 +30
Lines 45424 47505 +2081
==========================================
+ Hits 22612 23238 +626
- Misses 20652 22059 +1407
- Partials 2160 2208 +48
... and 35 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/test install-vc7 |
/test install-vc7,upgrade-vc7 |
Tests failed! Build no: 4695 |
Cluster Generation A/B Results: |
…ustom cluster bootstrap scenario
…om cluster bootstrap case
…nning all the integration tests
d9e1a87
to
027f934
Compare
027f934
to
c45cc8c
Compare
toBeCloned = false | ||
for _, clonePackage := range packagesToBeCloned { | ||
if cbPackage == clonePackage { | ||
toBeCloned = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Wondering if we could break
here (as more iterations of the loop won't change toBeCloned
)?
What this PR does / why we need it
Add logic to put cluster labels and package labels(tkg.tanzu.vmware.com/package-name) on resources for custom cluster bootstrap scenario
Simplify the logic of reconciliation of existing cluster bootstrap in HandleExistingClusterBootstrap and CloneReferencedObjectsFromCBPackages by making cloneSecretRef and cloneProviderRef functions idempotent
Add check for package name labels on config resources for Calico test and load balancer and ingress (AKO) test
Which issue(s) this PR fixes
Fixes #4568
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer