Update GO v1.21 #476
Update GO v1.21 #476
Conversation
mpanchajanya
force-pushed
the
go-update
branch
from
534b295 to
8f22775
Compare
mpanchajanya
force-pushed
the
go-update
branch
from
8f22775 to
0a62812
Compare
| - EXC0011 # disable excluding of issues about missing package comments from stylecheck | ||
|
|
||
| # Show all errors for all linters. Setting these to 0 disables limiting error reporting. | ||
| - EXC0011 |
There was a problem hiding this comment.
Can we keep the comment as it is.
| - EXC0011 | |
| - EXC0011 # disable excluding of issues about missing package comments from stylecheck |
| - varcheck | ||
| - whitespace | ||
| - bodyclose | ||
| - noctx | ||
| - rowserrcheck | ||
| - structcheck | ||
| - unparam |
There was a problem hiding this comment.
Are these removals intentional?
There was a problem hiding this comment.
same question. If they are, in the future it would be good to mention in the PR description or a comment in this file
There was a problem hiding this comment.
Yes these are deprecated in new golangci-lint version. Updated the PR description
| @@ -96,6 +96,7 @@ func runLocalListener() error { | |||
| mux := http.NewServeMux() | |||
| mux.HandleFunc("/callback", callbackHandler) | |||
| tokenExchange, tokenExchangeComplete = context.WithCancel(context.TODO()) | |||
| //nolint:gosec | |||
There was a problem hiding this comment.
If possible might be better to add a comment on why we are skipping this.
| if hdr.Typeflag == tar.TypeReg || hdr.Typeflag == tar.TypeRegA { | ||
| if hdr.Typeflag == tar.TypeReg { |
There was a problem hiding this comment.
Is this change intentional?
mpanchajanya
force-pushed
the
go-update
branch
from
0a62812 to
dbff5e1
Compare
| - varcheck | ||
| - whitespace | ||
| - bodyclose | ||
| - noctx | ||
| - rowserrcheck | ||
| - structcheck | ||
| - unparam |
There was a problem hiding this comment.
same question. If they are, in the future it would be good to mention in the PR description or a comment in this file
| - "!$test" | ||
| allow: | ||
| - $gostd | ||
| - github.com/AlecAivazis/survey/v2 |
There was a problem hiding this comment.
this sounds like sounding that is rather cumbersome to maintain. Can you summarize when a pattern needs to be added to the allow list, because it does not seem to cover all of go.mod
|
Addressing the comments as part of #490 |
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer