Remove API code for deprecated DHCP config #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanjun Zhou <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
==========================================
+ Coverage 73.29% 73.36% +0.06%
==========================================
Files 118 118
Lines 16397 16363 -34
==========================================
- Hits 12019 12004 -15
+ Misses 3591 3577 -14
+ Partials 787 782 -5
|
dantingl
approved these changes
Jan 2, 2025
NSX API schema is not changed, and they still keep the dhcp_config field in nsx subnet. |
TaoZou1
approved these changes
Jan 3, 2025
yanjunz97
added a commit
to yanjunz97/nsx-operator
that referenced
this pull request
Jan 3, 2025
The PR removes the old API code for deprecated DHCP config and updates the Subnet e2e test with DHCP switch check. Signed-off-by: Yanjun Zhou <[email protected]>
yanjunz97
added a commit
that referenced
this pull request
Jan 3, 2025
The PR removes the old API code for deprecated DHCP config and updates the Subnet e2e test with DHCP switch check. Signed-off-by: Yanjun Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR remove the old API code for deprecated DHCP config and update the Subnet e2e test with DHCP switch check.