[cherry-pick]Improve SubnetDHCPConfig validation rule (#976) #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subnet controller will update the SubnetSpec as the following when
either accessMode or ipv4SubnetSize is not provided.
```
spec:
accessMode: Public
ipv4SubnetSize: 64
subnetDHCPConfig:{}
```
Thus we need another validation rule on subnetDHCPConfig to prevent
subnetDHCPConfig being updated from no mode specified to
DHCPServer/DHCPRelay mode.
Signed-off-by: Yanjun Zhou <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.2.0 #978 +/- ##
=======================================
Coverage 74.03% 74.03%
=======================================
Files 118 118
Lines 16397 16397
=======================================
Hits 12139 12139
Misses 3477 3477
Partials 781 781
|
dantingl
approved these changes
Dec 26, 2024
lxiaopei
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subnet controller will update the SubnetSpec as the following when either accessMode or ipv4SubnetSize is not provided.
Thus we need another validation rule on subnetDHCPConfig to prevent subnetDHCPConfig being updated from no mode specified to DHCPServer/DHCPRelay mode.